btshowmetainfo doesn't verify the file type

Bug #108101 reported by Lars Ljung
2
Affects Status Importance Assigned to Milestone
bittorrent (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: bittorrent

Btshowmetainfo should check if the file is a bittorrent file before trying to extract any information. As it is now it reads the whole file into memory before trying to decode it. It the file is big, let's say a 700 MiB ISO-image, this will take a long time and the process can't even be killed with "kill -9".

Revision history for this message
Lars Ljung (larslj) wrote :

Added a patch to solve the problem, it just checks for "d8:announce" and prints an error message it the file is of the wrong type.

Revision history for this message
Andrea Veri (av) wrote :

Debdiff which includes this patch has been added as attachment.

Thanks for your work.

Changed in bittorrent:
status: Unconfirmed → Confirmed
Revision history for this message
Alexander Sack (asac) wrote :

if the first 11 bytes in torrent files really are 'd8:announce', then this debdiff looks fine.

Revision history for this message
Andrea Veri (av) wrote :

bittorrent (3.4.2-11ubuntu2) gutsy; urgency=low

   * Added 01_btshow-meta-info patch, now bittorrent checks
     file type before trying to extract any information. (LP: #108101)

 -- Andrea Veri <email address hidden> Thu, 31 May 2007 11:32:51 +0200

Changed in bittorrent:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.