[UBUNTU 22.04] BINUTILS: Adding new platform name IBM z16

Bug #1974115 reported by bugproxy
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
Skipper Bug Screeners
binutils (Ubuntu)
Fix Released
Canonical Foundations Team
Fix Released
Matthias Klose
Fix Released
Canonical Foundations Team

Bug Description

SRU Justification:


 * As of today the architectural (level) name 'arch14' is used
   as CPU name for the new IBM z16 system.

 * The real name 'z16' couldn't be used until officially announced.

 * That happened meanwhile, hence we can now add and use the real name.

[Test Plan]

 * Check if the same (proper) opcodes are detected on an IBM z16
   system with and without the patch.
   Since only the identification and name of a z16 system was modified.

 * Or the simplest test is probably to check
   (after having 'binutils' installed on an Ubuntu 22.04 s390x system)
   if not only:
   'as -m64 -march=arch14 --target-help'
   but also:
   'as -m64 -march=z16 --target-help'
   succeeds and leads to the same output.
   (As it does for '-march=arch13' and '-march=arch15'.)

[Where problems could occur]

 * Issues could happen if the conditional statement that look
   for architectural / CPU name are paired wrongly, since:

 * 'z16' belongs to 'arch14', 'z15' to 'arch13', etc.

 * If these pairs are not handled correctly,
   or the identification is erroneous
   a wrong system might be identified and wrong instructions used etc.


 * This is a hardware enablement SRU to enhance the IBM z16 support.


After the announcement support for the official machine name z16 has been added to binutils. Please consider picking up the following patch from 2.37 branch:

commit e24d2a2d11008aa363366c1087219f3e3405782a (origin/binutils-2_37-branch, 2.37)

    IBM zSystems: Add support for z16 as CPU name.

    So far z16 was identified as arch14. After the machine has been
    announced we can now add the real name.

    (cherry picked from commit 69341966def7f6551bc4452684136831d6a6941c)
    (cherry picked from commit fb4d148004f28494e9fb5d2400a13308d07a7988)

bugproxy (bugproxy)
tags: added: architecture-s39064 bugnameltc-198301 severity-high targetmilestone-inin---
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → linux (Ubuntu)
Frank Heimes (fheimes)
affects: linux (Ubuntu) → binutils (Ubuntu)
Changed in ubuntu-z-systems:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
importance: Undecided → Medium
Changed in binutils (Ubuntu):
assignee: Skipper Bug Screeners (skipper-screen-team) → Canonical Foundations Team (canonical-foundations)
Frank Heimes (fheimes)
tags: added: rls-kk-incoming
tags: added: fr-2396
tags: removed: rls-kk-incoming
Frank Heimes (fheimes)
Changed in binutils (Ubuntu Jammy):
assignee: nobody → Canonical Foundations Team (canonical-foundations)
Changed in binutils (Ubuntu Kinetic):
importance: Undecided → Medium
Changed in binutils (Ubuntu Jammy):
importance: Undecided → Medium
Frank Heimes (fheimes)
description: updated
Matthias Klose (doko)
Changed in binutils (Ubuntu Kinetic):
status: New → Fix Released
Changed in binutils (Ubuntu Jammy):
status: New → In Progress
assignee: Canonical Foundations Team (canonical-foundations) → Matthias Klose (doko)
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: New → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello bugproxy, or anyone else affected,

Accepted binutils into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/binutils/2.38-4ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in binutils (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: In Progress → Fix Committed
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (binutils/2.38-4ubuntu2)

All autopkgtests for the newly accepted binutils (2.38-4ubuntu2) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

glibc/2.35-0ubuntu3.1 (armhf)
sagemath/9.5-4 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].


[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Brian Murray (brian-murray) wrote :

I've blindly retried both of these failures.

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2022-09-01 04:48 EDT-------
@Canonical: Hi Brian,
the test / verification on our side will be delayed as our SME is out on vacation.
We should have an answer by the end of next week.

Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2022-09-13 10:40 EDT-------
I've installed binutils 2.38-4ubuntu2 on jammy. With that the -march=z16 option is accepted by 'as'. So looks good to me.

No idea about the regressions mentioned above. I don't see how an IBM zSystems only patch can affect builds on arm and amd64.

Revision history for this message
Frank Heimes (fheimes) wrote :

Hi Andreas, thanks for the verification, I'm going to adjust the tags accordingly.

Don't worry about the potential regression, it's an automated mail based on the results of the autopkgtests that run automatically while processing such an SRU like this - and binutils trigger a lot of tests.
Such regressions can be caused by several different things, like a different package that is handled at the same time and triggers similar tests or a flaky test etc. - we deal with it.
(IF we think it's due to s390x-specific code, we may reach out to you ;-)

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
bugproxy (bugproxy)
tags: added: targetmilestone-inin2204
removed: targetmilestone-inin---
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package binutils - 2.38-4ubuntu2

binutils (2.38-4ubuntu2) jammy-proposed; urgency=medium

  * SRU: LP: #1982105. Update from the binutils 2.38 branch:
    - IBM zSystems: Add support for z16 as CPU name. LP: #1974115.
    - Fix PR libctf/29242, linking together multiple objects derived from
      the same source.
    - PowerPC64: fix assertion in ppc_build_one_stub with -Os code.
    - Fix PR ld/29216, x86: Properly handle IFUNC function pointer reference.
    - AArch64: Enable FP16 by default for Armv9-A.
    - Fix PR binutils/29142, segv in ar with empty archive and libdeps
    - M68K: avoid quadratic slowdlow in label alignment check.
    - Adjust ld ctf test for 32-bit targets.

binutils (2.38-4ubuntu1) kinetic; urgency=medium

  * Merge with Debian; remaining changes:
    - Build from upstream sources.

binutils (2.38-4) unstable; urgency=medium

  * Update from the binutils 2.38 branch:
    - Fix PR ld/29087, x86: invalid relocation against protected symbol.
    - s390: Add DT_JMPREL pointing to .rela.[i]plt with static-pie.
    - Fix PR ld/22263, s390: Avoid dynamic TLS relocs in PIE.
    - Fix PR libctf/28933: ld: diagnose corrupted CTF header cth_strlen.
    - Fix PR 28885.
    - PR28959, obdump doesn't disassemble mftb instruction.
    - PowerPC64 DT_RELR relative reloc addresses. LP: #1978129.
  * Fix reproducible builds: source tarball embeds build user and group.
    Closes: #1010238.

 -- Matthias Klose <email address hidden> Tue, 19 Jul 2022 12:17:47 +0200

Changed in binutils (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for binutils has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.