Lost its Modalises: package header

Bug #1089943 reported by Martin Pitt on 2012-12-13
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bcmwl (Ubuntu)
High
Martin Pitt
Precise
Undecided
Unassigned
Raring
High
Martin Pitt

Bug Description

On December 12, ubuntu-drivers-common's autopkgtest started failing because thebcmwl-kernel-source driver is not being autodetected any more.

The current version 6.20.155.1+bdcom-0ubuntu1 has lots its Modaliases: package header. debian/control still has it, so something from the upstream changes may have caused this.

Martin Pitt (pitti) on 2012-12-13
Changed in bcmwl (Ubuntu):
status: New → Incomplete
status: Incomplete → In Progress
importance: Undecided → High
assignee: nobody → Martin Pitt (pitti)
Martin Pitt (pitti) wrote :

This looks related:

 +MODULE_LICENSE("MIXED/Proprietary");
 +
- static struct pci_device_id wl_id_table[] = {
- { PCI_VENDOR_ID_BROADCOM, 0x4311, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
- { PCI_VENDOR_ID_BROADCOM, 0x4312, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+ static struct pci_device_id wl_id_table[] =
+ {
+ { PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
+--

(from http://launchpadlibrarian.net/125452033/bcmwl_5.100.82.112%2Bbdcom-0ubuntu4_6.20.155.1%2Bbdcom-0ubuntu1.diff.gz)

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.20.155.1+bdcom-0ubuntu2

---------------
bcmwl (6.20.155.1+bdcom-0ubuntu2) raring; urgency=low

  * Drop parsing of src/src/wl/sys/wl_linux.c, as the current upstream version
    dropped all useful vendor matches in its pci_device_id struct and now has
    a broken modalias. Keep a static debian/bcmwl-kernel-source.modaliases
    instead which matches on any Broadcom network device (vendor 14E4 class 02
    subclass 80). This brings back a proper "Modaliases:" package header.
    (LP: #1089943)
 -- Martin Pitt <email address hidden> Thu, 13 Dec 2012 16:02:24 +0100

Changed in bcmwl (Ubuntu Raring):
status: In Progress → Fix Released

Hello Martin, or anyone else affected,

Accepted bcmwl into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/bcmwl/6.20.155.1+bdcom-0ubuntu0.0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Adam Conrad (adconrad) on 2013-01-17
Changed in bcmwl (Ubuntu Precise):
status: New → Fix Committed
Timo Jyrinki (timo-jyrinki) wrote :

Modaliases header is there in the precise-proposed version: pci:v000014E4d*sv*sd*bc02sc80i*. Driver seems to work fine on Latitude 2110 (BCM43224).

tags: added: verification-done
removed: verification-needed

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.20.155.1+bdcom-0ubuntu0.0.1

---------------
bcmwl (6.20.155.1+bdcom-0ubuntu0.0.1) precise-proposed; urgency=low

  [ Alberto Milone ]
  * New upstream release (LP: #923809).
  * Add 0004-Add-support-for-Linux-3.2.patch:
    - Make sure the patch can always be applied.
  * Add 0005-Add-support-for-Linux-3.4.0.patch:
    - Thanks to Eugene San for the patch (LP: #994255).
  * debian/control:
    - Drop all the dependencies on the linux-headers.
  * debian/dkms.conf.in:
    - Always apply all patches (LP: #1020059).

  [ Martin Pitt ]
  * debian/bcmwl-kernel-source.postinst:
    - Silence the errors from rmmod about the modules not being
      loaded. This is fully expected, and just causes confusion,
      as well as autopkgtest failures.
    - Mirror the actions of the installed modprobe.d files,
      i.e. rmmod the b43 driver and try to modprobe wl, so
      that this package works right after installation.
      (LP: #1065827)
    - Drop duplicate #DEBHELPER# token. It does not currently
      expand to anything, but it looks confusing.
  * debian/rules, debian/bcmwl-kernel-source.modaliases:
    - Drop parsing of src/src/wl/sys/wl_linux.c, as the current
      upstream version dropped all useful vendor matches in its
      pci_device_id struct and now has a broken modalias. Keep
      a static debian/bcmwl-kernel-source.modaliases instead
      which matches on any Broadcom network device (vendor 14E4
      class 02 subclass 80). This brings back a proper
      "Modaliases:" package header (LP: #1089943).
 -- Alberto Milone <email address hidden> Thu, 17 Jan 2013 12:38:17 +0100

Changed in bcmwl (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers