builtins/help.def: Passes ngettext() result to printf() as format string
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
bash (Ubuntu) |
Confirmed
|
High
|
Unassigned | ||
Trusty |
Confirmed
|
High
|
Unassigned |
Bug Description
[Impact]
Breaks build on arm64 in trusty:
../../.
[Test case]
Check it builds
[Regression potential]
Indefinitely low. All we do is add
"%s",
between printf( and ngettext(...
[Other info]
The same code works fine on all other architectures and newer releases, but it seems broken anyway: We are passing the return value of ngettext() to printf() as the format string, which is unsafe.
We should evaluate why that works elsewhere and probably also do the same fix in other branches, but I'll leave that to someone else to decide. My intention here is to just get the trusty SRU for bug 1644048 building on all platforms.
summary: |
- 4.3-7ubuntu1.6 FTBFS on arm64 + 4.3-7ubuntu1.6 FTBFS on arm64 only with format-security error |
tags: | added: patch |
description: | updated |
Changed in bash (Ubuntu Trusty): | |
status: | Confirmed → In Progress |
description: | updated |
description: | updated |
tags: | added: ftbfs |
Changed in bash (Ubuntu Trusty): | |
importance: | Undecided → High |
Changed in bash (Ubuntu): | |
importance: | Undecided → High |
Apparently zesty has the same code in it, but it weirdly works there.