Bash completion for wget -o doesn't escape spaces.

Bug #435055 reported by Angus
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bash-completion (Ubuntu)
Low
Thierry Carrez

Bug Description

Binary package hint: bash-completion

Ubuntu version: 9.04
wget: 1.11.4-2ubuntu1
bash-completion: 20080705ubuntu3

When using the -O option for wget and trying to complete a directory name or filename, spaces aren't escaped.

Revision history for this message
Martin Eve (martineve) wrote :

I am able to reproduce this bug on Jaunty and Karmic i386.

Steps:

wget -o ~/folder/start-of-folder-with-spaces-in-it<TAB>

Expected result:

wget -o /home/martin/fully\ escaped\ name\ of\ folder

Actual result:

wget -o /home/martin/fully escaped name of folder

Changed in bash-completion (Ubuntu):
status: New → Confirmed
summary: - Bash completion for wget doesn't escape spaces.
+ Bash completion for wget -o doesn't escape spaces.
Revision history for this message
Martin Eve (martineve) wrote :

Patch to fix attached.

Works by removing wget from the list of programs that supposedly don't take filenames.

Revision history for this message
Martin Eve (martineve) wrote :

Here is an attached path that fixes several issues with the previous, following a discussion in #ubuntu-motu:

target is now lucid
LP: notation used in changelog
quilt patch system used

Revision history for this message
Thierry Carrez (ttx) wrote :

@Martin: the patch no longer applies to updated bash-completion_1.1-3, any chance you could revise it ?

Revision history for this message
Martin Eve (martineve) wrote :

@Thierry: I doubt I will be able to do this in time for lucid; I'll have a go this week. The latest bash-completion package (unstable) does work. Could be worth porting in their "ssh" file...

Revision history for this message
Thierry Carrez (ttx) wrote :

Martin: I'm not sure I understand what you're saying. Both debian unstable and us have 1:1.1-3. Does that mean the bug is already fixed ? If not, let us know when you have an updated patch ready by resubscribing sponsors. Thanks !

Revision history for this message
Martin Eve (martineve) wrote :

Hi Thierry,

Apologies for that garbled last message - I've been somewhat ill lately! I was actually referring to another bug that I will shortly fix.

In the meanwhile, here is an updated patch for lucid to fix this minor annoyance.

Best,

Martin

Revision history for this message
Martin Eve (martineve) wrote :

Note: this bug is fixed upstream in *version control*.

However, upstream will certainly not release in time for Lucid, hence the patch here.

Thierry Carrez (ttx)
Changed in bash-completion (Ubuntu):
assignee: nobody → Thierry Carrez (ttx)
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Thierry Carrez (ttx) wrote :

Uploading with minor changes (LP: #xxxxxx rather than LP:xxxxxx, updated maintainer in control, more verbose changelog).

I couldn't find that patch looking at upstream git. Could you please forward your patch to Debian and upstream ?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bash-completion - 1:1.1-3ubuntu1

---------------
bash-completion (1:1.1-3ubuntu1) lucid; urgency=low

  * debian/patches/bash-completion-wget-o-fix:
    Fix directory escaping for wget -O (LP: #435055)
 -- Martin Eve <email address hidden> Tue, 06 Apr 2010 11:11:04 +0100

Changed in bash-completion (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Martin Eve (martineve) wrote :

Patch forwarded to bash-completion mailing list.

Revision history for this message
Martin Eve (martineve) wrote :
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers