wildcard incorrect completion

[Rolf Leggewie]

steps to reproduce (verified on trusty)

$ touch /tmp/file01.txt;touch /tmp/file11.txt
$ file /tmp/fileTAB
file01.txt file02.txt
$ file /tmp/file*TAB

the last command will then incorrectly complete to

$ file /tmp/file01.txt

[Peter Cordes (peter-cordes)]

The problem is a lack of quoting in /usr/share/bash_completion/bash_completion.

set -x revealed where the problem happens: in a compgen -X -f. $quoted is used without quotes, so it expands, and you get the first of however many glob expansions.

 There are two unquoted uses of $quoted in _filedir(). Fixing them fixed my tab-expanding-globs problem.

 Don't forget to apply the fix for bug 1390061, too. Another case of lack of quoting leading to code that doesn't do what was intended.

[Peter Cordes (peter-cordes)]

submitted upstream as
https://alioth.debian.org/tracker/index.php?func=detail&aid=314891&group_id=100114&atid=413095

bug 1390061 is fixed upstream, as a side-effect of reworking the relevant code.

[Rolf Leggewie (r0lf)]

Thanks, Peter.

The problem is still the same at least for vivid. I can't see the relevant upstream bug at the moment which is only visible to logged in members. If there is something to backport, we should.

[Dabe Murphy (dabe-c)]

In addition to the unquoted "$quoted" that @peter-cordes mentioned, there's another bug in the _filedir() function:

    --- /usr/share/bash-completion/bash_completion--OLD 2015-08-19 19:58:22.734667377 -0500
    +++ /usr/share/bash-completion/bash_completion 2016-01-05 15:56:50.442988910 -0500
    @@ -604,6 +604,8 @@
             # 2>/dev/null for direct invocation, e.g. in the _filedir unit test
             compopt -o filenames 2>/dev/null
             COMPREPLY+=( "${toks[@]}" )
    + else
    + compopt -o bashdefault 2>/dev/null
         fi
     } # _filedir()

This lets you eat your cake and have it, too: you can keep your "shopt -s progcmp" bash_completion AND if that doesn't find a match, it will fall back to using bash's default glob-handling.

(This also solves Bug 1361404)

[Tv (tv42)]

This bug seems to affect 17.10 too. 3+ years and going on strong.