Remove access key for Repeat button

[Vish]

Binary package hint: banshee

Banshee provides an access key for the Repeat button, toolbar button, [it's a statusbar with button, so kinda acts like a toolbar button]
Pressing "Alt" underlines the access keys in the Repeat button. Access keys should *not* be provided for toolbar buttons.

From HIG <http://library.gnome.org/devel/hig-book/stable/input-keyboard.html.en#choosing-access-keys> :
"Give all labelled components an access key (underlined letter), with the exception of toolbar controls which would use up too many access key combinations."

It's not a regular menu either, so access is not in a consistent way.

Pressing the "Alt" keys should not highlight the Repeat options in the button.

[Chow Loong Jin (hyperair)]

On Saturday 11,December,2010 03:19 AM, Vish wrote:
> Public bug reported:
>
> Binary package hint: banshee
>
> Banshee provides an access key for the Repeat button, toolbar button, [it's a
> statusbar with button, so kinda acts like a toolbar button] Pressing "Alt"
> underlines the access keys in the Repeat button. Access keys should *not* be
> provided for toolbar buttons.
>
>> From HIG
>> <http://library.gnome.org/devel/hig-book/stable/input-keyboard.html.en#choosing-access-keys>
>> :
> "Give all labelled components an access key (underlined letter), with the
> exception of toolbar controls which would use up too many access key
> combinations."

I actually interpret this as "It isn't mandatory to add an access key for
toolbar controls as they use up too many access key combinations," rather than
"Toolbar controls must not have access keys"

> It's not a regular menu either, so access is not in a consistent way.
>
> Pressing the "Alt" keys should not highlight the Repeat options in the
> button.

There's an important difference between the Repeat button and a normal toolbar
button. The repeat button is primarily text. A toolbar button is primarily an icon.

Rather than using "A" and "E" for repeat all/single, or whatnot, how about using
"R" as an access key to open up that menu?

--
Kind regards,
Loong Jin

[Vish (vish)]

> There's an important difference between the Repeat button and a normal toolbar
> button. The repeat button is primarily text. A toolbar button is primarily an icon.
>
It basically behaves like a combobox. And comboboxes on toolbars dont have access keys either.
I'm not sure why the combobox is not used instead. Maybe we can file a separate bug about switching to a combobox. Banshee has some weird non-GNOME UI in several places.

> Rather than using "A" and "E" for repeat all/single, or whatnot, how about using
> "R" as an access key to open up that menu?
>
That would work if only if the button was :
- Repeat
 -- Repeat All
 -- Repeat SIngle
 -- Repeat Off

Which would be making it a menu.

[Chris Wilson (notgary-deactivatedaccount)]

Thanks a lot for reporting this, however since Banshee is due to be dropped from the default installation, this bug no longer constitutes a papercut.

More information on what constitutes a papercut may be found here https://wiki.ubuntu.com/PaperCut

[Chow Loong Jin (hyperair)]

  affects hundredpapercuts
  status new

The discussion regarding Banshee is still ongoing and a decision has not been
made yet. Please wait a while longer before closing all these bugs.

--
Kind regards,
Loong Jin

[Timothy Arceri (t-fridey)]

If anyone is interested in working on this bug I have detailed what I think needs to be done in the code in the upstream bug report comment 9: https://bugzilla.gnome.org/show_bug.cgi?id=619746#c9

[Chris Wilson (notgary-deactivatedaccount)]

Thanks a lot for reporting this, however since Banshee is due to be dropped from the default installation, this bug no longer constitutes a papercut.

More information on what constitutes a papercut may be found here https://wiki.ubuntu.com/PaperCut