icons in music source and music folder dropdown are different size

Bug #683609 reported by Andreas Nilsson on 2010-12-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Banshee
Fix Released
Medium
One Hundred Papercuts
Low
Jensen Somers
banshee (Ubuntu)
Low
Unassigned

Bug Description

Binary package hint: banshee

(Originally filed as https://bugzilla.gnome.org/show_bug.cgi?id=611796 but filing here too so we can track this as a papercut)

It seems the icons in the two dropdowns are of different size.
The ones in Music source looks like 24x24 and the ones in Music folder looks
like 16x16 (and this seems to be the size that is most common in GNOME
dropdowns).

A possible fix would be to make the ones in Music source dropdown 16x16 as
well. Let me know if there are any new icons that needs to be drawn.

Vish (vish) wrote :
Changed in banshee (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Changed in hundredpapercuts:
assignee: nobody → Papercuts Ninja (papercuts-ninja)
importance: Undecided → Low
milestone: none → nt1-music
status: New → Triaged
Buttink (buttink) wrote :

Is this still open? Its hard to tell with Faenza Icon set. I did go into the source and find

@ 62 of Banshee.Prefrences.PageComboBox.cs
                    Banshee.Gui.IconThemeUtils.LoadIcon (page.IconName, 22),

which can be changed to 16. Right now, I'm digging into the preferences files to find how it draws the dropdown for Music folder to see its size.

Jensen Somers (jsomers) wrote :

I attached a patch to the original Gnome bug report yesterday which uses the Gtk.Icon.SizeLookup () function to determine the actual size of the theme icons (see https://bugzilla.gnome.org/attachment.cgi?id=175841&action=edit), because 16 is not a guaranteed size for all themes and all icon sets. The folder list is a default Gtk folder browser control, so there's no work to be done on that one.

But it was pointed out in the original bug report that the reason it's so large and bold is most likely done to have it stand out a bit. If that's the case I agree with Andreas that it should be converted into a sidebar. That looks to be more consistent with other applications and similar screens.

Unfortunately that requires more work than I have time for right now, so feel free to take a look at that, but make sure you notify people via the original Gnome bug report so the Banshee developers are aware that someone is working on the issue.

Changed in banshee:
importance: Unknown → Medium
status: Unknown → New
Changed in banshee:
status: New → Fix Released
Vish (vish) on 2011-01-10
Changed in hundredpapercuts:
assignee: Papercuts Ninja (papercuts-ninja) → Jensen Somers (jsomers)
status: Triaged → Fix Committed
Changed in banshee (Ubuntu):
status: Triaged → Fix Committed
Changed in hundredpapercuts:
status: Fix Committed → Fix Released
Changed in banshee (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.