Indicator applet is not aware of banshee window

[Tim Rørstrøm]

Binary package hint: banshee-community-extensions

The banshee application indicator is not aware of the state of the banshee window, i.e. the "Show Banshee" item of the indicator menu, is not consistent with the window actually being open or not.

If the banshee window is opened by clicking "Show Banshee" in said menu, and then closed though the close button of the title bar, there is no problem; however, if the banshee window is opened by other means (such as through Docky), the indicator applet, does not recognise the banshee window as being open, and as such does not show a tick-mark, meaning that the user will have to click the "Show Banshee" item twice in order to hide the banshee window (with an extra click to show the menu for a second time).

TEST CASE:
1. Start Banshee.
2. Disable the Notification Area Icon extension
3. Enable the AppIndicator extension
4. Quit Banshee and restart it.
5. Hide the main window by clicking the "X"
6. Verify that the Banshee indicator shows no tick next to the "Show Banshee" menu item.
7. Reopen Banshee's window by clicking on the Banshee launcher again, or by running "banshee --show"
8. Verify that the Banshee indicator shows a tick next to the "Show Banshee" menu item.

PATCH: http://gitorious.org/banshee-community-extensions/banshee-community-extensions/commit/90fc106d7bea4d3ef0ae25fb597d20b834996255

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: banshee-extension-appindicator 1.6.0-1ubuntu5
ProcVersionSignature: Ubuntu 2.6.32-22.33-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-22-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Sun May 23 00:48:05 2010
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Beta i386 (20100406)
PackageArchitecture: all
ProcEnviron:
 LC_COLLATE=da_DK.UTF-8
 PATH=(custom, user)
 LANG=en_DK.UTF-8
 SHELL=/bin/bash
SourcePackage: banshee-community-extensions

[Chow Loong Jin (hyperair)]

Fixed committed upstream, see http://gitorious.org/banshee-community-extensions/banshee-community-extensions/commit/90fc106d7bea4d3ef0ae25fb597d20b834996255

[Chow Loong Jin (hyperair)]

Fixed in 1.6.1-1ubuntu1

[Jonathan Riddell (jr)]

1.6.1-1ubuntu1~lucid1 is waiting in lucid-proposed unapproved queue. It needs approval from ubuntu-sru to be accepted. I don't see a patch on this bug (or the other three addressed by the same upload) for them to approve. I don't see a test case for it to be tested with.

[Martin Pitt (pitti)]

Please consider to not add a new binary package with a new feature in an SRU.

[Chow Loong Jin (hyperair)]

On Thu, 01 Jul 2010 20:03:19 -0000
Martin Pitt <email address hidden> wrote:

> Please consider to not add a new binary package with a new feature in
> an SRU.
>

Sorry about that, I forgot I re-enabled it for Maverick. I'll make
another upload disabling this.

--
Kind regards,
Chow Loong Jin

[Martin Pitt (pitti)]

Accepted banshee-community-extensions into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Chow Loong Jin (hyperair)]

I can confirm that version 1.6.1-1ubuntu1~lucid2 of the AppIndicator extension has fixed this issue for me.

[Launchpad Janitor (janitor)]

This bug was fixed in the package banshee-community-extensions - 1.6.1-1ubuntu1~lucid2

---------------
banshee-community-extensions (1.6.1-1ubuntu1~lucid2) lucid-proposed; urgency=low

  * Disable Telepathy extension again, it wasn't supposed to have been
    enabled for Lucid's SRU

banshee-community-extensions (1.6.1-1ubuntu1~lucid1) lucid-proposed; urgency=low

  * No change upload to lucid-proposed
  * Bugs fixed:
    + AppIndicator extension not aware of window status (LP: #584364)
    + LiveRadio extension doesn't work with shoutcasts stations (LP: #572819)
    + StreamRecorder extension does not work with any webradio (LP: #581832)
    + Lyrics extension does not honour "Write metadata to files" setting
      (LP: #586174)
 -- Chow Loong Jin <email address hidden> Fri, 02 Jul 2010 18:52:07 +0800