backuppc/smb: BackupPC failes to backup SMB shares after smbclient update

Bug #1576187 reported by DipSwitch on 2016-04-28
98
This bug affects 15 people
Affects Status Importance Assigned to Milestone
backuppc
Unknown
Unknown
backuppc (Debian)
Unknown
Unknown
backuppc (Ubuntu)
Undecided
Unassigned
Trusty
Undecided
Andreas Hasenack
Xenial
Undecided
Andreas Hasenack
Bionic
Undecided
Unassigned

Bug Description

[Impact]

An update to samba changed the behavior of smbclient and this broke backuppc's parsing of that output, causing smb backup jobs to fail.

[Test Case]

We will want to test four scenarios:
a) old samba, old backuppc: should work
b) old samba, new backuppc: should work
c) new samba, new backuppc: should work
d) new samba, old backuppc: should fail (this bug)

I suggest to proceed in the order listed above, as it's easier to downgrade backuppc (just one package) than to downgrade the whole samba suite. Alternatively, a new VM/LXD could be used for each scenario, of course.

The steps below are generic.

* Install samba and backuppc, and accept all defaults. Keep in mind which scenario from above you are testing, and adjust /etc/apt/sources.list accordingly to either include or not updates.

sudo apt update
sudo apt install samba backuppc

* If you want to use the web interface, take note of the password given during the installation and restart apache2 at the end:
sudo service apache2 restart

* If you want to regenerate the password, install apache2-utils and run the htpasswd command:
sudo apt install apache2-utils
sudo htpasswd /etc/backuppc/htpasswd backuppc

* Add this snippet to the end of /etc/samba/smb.conf:
[public]
  path = /public
  guest ok = yes
  read only = no

* Create /c and copy some content into it:
sudo mkdir /public
sudo chmod 1777 /public
sudo cp -a /usr/bin /public

* restart the samba services
sudo service smbd restart; sudo service nmbd restart

* overwrite /etc/backuppc/localhost.pl with this;
$Conf{XferMethod} = 'smb';
$Conf{XferLogLevel} = 1;
$Conf{ClientCharset} = '';
$Conf{ClientCharsetLegacy} = 'iso-8859-1';
$Conf{SmbShareName} = 'public';
$Conf{SmbShareUserName} = '';
$Conf{SmbSharePasswd} = '';

* Now you are ready to run the backup command. Depending on the scenario being tested, it will work or fail.

This is the working scenario:
$ sudo -u backuppc -H /usr/share/backuppc/bin/BackupPC_dump -f localhost
started full dump, share=C$
xferPids 7009,7008
full backup complete
$ echo $?
0

This is the failing scenario:

$ sudo -u backuppc -H /usr/share/backuppc/bin/BackupPC_dump -f localhost
started full dump, share=C$
xferPids 11008,11007
dump failed: No files dumped for share C$
link localhost
$ echo $?
2

[Regression Potential]
Since there is a tight coupling between samba and backuppc, there could be a regression for people who are not using the latest versions of each package. Therefore, I added specific tests for that to this SRU: all combinations of old and new packages of both samba and backuppc. Prior to uploading, I performed these tests myself and all combinations work as expected, with the only failing one being this bug that is being fixed.

That being said, there is no guarantee that future samba or backuppc updates won't break again, because of this tight coupling. This package could benefit from DEP8 tests in that area.

[Other Info]
The fix adopted in Debian and Ubuntu Bionic onwards is different than the one presented here. The one used here is what was merged upstream, and doesn't require a configuration file change. I chose to leave bionic alone for now, since the bug is fixed there, just differently.

[Original Description]

After the current update of samba 4.1.6 to 4.3.8 samba on trusty the BackupPC smb transfer is broken.

Several bugs in smbclient >= 4.1.6 in combination with BackupPC:
 https://bugzilla.samba.org/show_bug.cgi?id=11642 (tarmode is no longer verbose and ignores verbose flag)
  - patch1 (reenable tarmode verbose, and skip inaccessible files) https://attachments.samba.org/attachment.cgi?id=11733
  - patch 2 (modified clitar.c for tarmode verbose) https://attachments.samba.org/attachment.cgi?id=11734
 https://bugzilla.redhat.com/show_bug.cgi?id=1294761 (mis-interpreted failure of new tar:\d+ lines) (fix: https://bugzilla.redhat.com/attachment.cgi?id=1111264&action=diff)

Package Information:

 0)root@essrv2:~ $ dpkg -l | grep -E "(smb|samba|backuppc)"
 ii backuppc 3.3.0-1ubuntu1 amd64 high-performance, enterprise-grade system for backing up PCs
 ii libpam-smbpass:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 pluggable authentication module for Samba
 ii libsmbclient:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 shared library for communication with SMB/CIFS servers
 ii python-samba 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Python bindings for Samba
 ii samba 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 SMB/CIFS file, print, and login server for Unix
 ii samba-common 2:4.3.8+dfsg-0ubuntu0.14.04.2 all common files used by both the Samba server and client
 ii samba-common-bin 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba common files used by both the server and the client
 ii samba-doc 2:4.3.8+dfsg-0ubuntu0.14.04.2 all Samba documentation
 ii samba-dsdb-modules 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba Directory Services Database
 ii samba-libs:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba core libraries
 ii samba-vfs-modules 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba Virtual FileSystem plugins
 ii smbclient 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 command-line SMB/CIFS clients for Unix

System information of the update:

 0)root@essrv2:~ $ grep samba /var/log/apt/history.log | sed "s|),|)\n|g" | grep -E "(samba|smb)"
 Upgrade: libpam-smbpass:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  python-samba:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  samba:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  samba-dsdb-modules:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  samba-common-bin:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  samba-libs:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  samba-doc:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  smbclient:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  samba-vfs-modules:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  samba-common:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
  libsmbclient:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)

Log of backup when failing:

 Running: /usr/bin/smbclient \\\\esrouter\\backups -U backup -E -d 1 -c tarmode\ full -TcrX - \*.sysdmp.tar.xz
 full backup started for share backups
 Xfer PIDs are now 25749,25748
 Domain=[E_SPIRIT] OS=[Windows 6.1] Server=[Samba 4.3.8-Ubuntu]
 tar:316 tarmode is now full, system, hidden, noreset, quiet
 tar:712 Total bytes received: 224900956
   create 644 0/0 138326 esrouter.2016-04-26.packages
   pool 644 0/0 136349 esrouter.2016-04-23.packages
   pool 644 0/0 27551 esrouter.2016-04-23.dpkg
   create 644 0/0 56037724 esrouter.2016-04-23.evh.tar.xz
   create 644 0/0 56017156 esrouter.2016-04-24.evh.tar.xz
   create 644 0/0 27964 esrouter.2016-04-26.dpkg
   pool 644 0/0 136349 esrouter.2016-04-24.packages
   create 644 0/0 138326 esrouter.2016-04-25.packages
   create 644 0/0 27964 esrouter.2016-04-25.dpkg
   pool 644 0/0 27551 esrouter.2016-04-24.dpkg
   create 644 0/0 56090628 esrouter.2016-04-26.evh.tar.xz
   create 644 0/0 56095068 esrouter.2016-04-25.evh.tar.xz
 tarExtract: Done: 0 errors, 4 filesExist, 327800 sizeExist, 77902 sizeExistComp, 12 filesTotal, 224900956 sizeTotal
 Got fatal error during xfer (No files dumped for share backups)
 Backup aborted (No files dumped for share backups)
 Saving this as a partial backup, replacing the prior one (got 12 and 0 files versus 0)
 Running: /usr/bin/smbclient \\\\esrouter\\backups -U backup -E -d 1 -c tarmode\ full\ verbose -TcrX - \*.sysdmp.tar.xz
 full backup started for share backups
 Xfer PIDs are now 23275,23274
 Domain=[E_SPIRIT] OS=[Windows 6.1] Server=[Samba 4.3.8-Ubuntu]
 tar:316 tarmode is now full, system, hidden, noreset, verbose
 tar:712 Total bytes received: 225006494
   create 644 0/0 56140872 esrouter.2016-04-27.evh.tar.xz
   pool 644 0/0 138326 esrouter.2016-04-26.packages
   pool 644 0/0 56017156 esrouter.2016-04-24.evh.tar.xz
   pool 644 0/0 138326 esrouter.2016-04-27.packages
   pool 644 0/0 27964 esrouter.2016-04-26.dpkg
   pool 644 0/0 27964 esrouter.2016-04-27.dpkg
   pool 644 0/0 136349 esrouter.2016-04-24.packages
   pool 644 0/0 138326 esrouter.2016-04-25.packages
   pool 644 0/0 27964 esrouter.2016-04-25.dpkg
   pool 644 0/0 27551 esrouter.2016-04-24.dpkg
   pool 644 0/0 56090628 esrouter.2016-04-26.evh.tar.xz
   pool 644 0/0 56095068 esrouter.2016-04-25.evh.tar.xz
 tarExtract: Done: 0 errors, 11 filesExist, 168865622 sizeExist, 168378417 sizeExistComp, 12 filesTotal, 225006494 sizeTotal
 Got fatal error during xfer (No files dumped for share backups)
 Backup aborted (No files dumped for share backups)
 Not saving this as a partial backup since it has fewer files than the prior one (got 12 and 0 files versus 12)

Log of working backup:

 Running: /usr/bin/smbclient \\\\esrouter\\backups -U backup -E -d 1 -c tarmode\ full -TcrX - \*.sysdmp.tar.xz
 full backup started for share backups
 Xfer PIDs are now 20343,20342
 tar_re_search set
 Domain=[E_SPIRIT] OS=[Unix] Server=[Samba 4.1.6-Ubuntu]
 tarmode is now full, system, hidden, noreset, verbose
 tar: dumped 12 files and directories
 Total bytes written: 223928320
   pool 644 0/0 55839072 esrouter.2016-04-13.evh.tar.xz
   pool 644 0/0 124612 esrouter.2016-04-13.packages
   pool 644 0/0 124612 esrouter.2016-04-14.packages
   pool 644 0/0 25011 esrouter.2016-04-11.dpkg
   pool 644 0/0 25011 esrouter.2016-04-12.dpkg
   pool 644 0/0 55829392 esrouter.2016-04-11.evh.tar.xz
   pool 644 0/0 25011 esrouter.2016-04-13.dpkg
   pool 644 0/0 124612 esrouter.2016-04-12.packages
   pool 644 0/0 124612 esrouter.2016-04-11.packages
   pool 644 0/0 25011 esrouter.2016-04-14.dpkg
   pool 644 0/0 55820624 esrouter.2016-04-12.evh.tar.xz
   create 644 0/0 55838452 esrouter.2016-04-14.evh.tar.xz
 tarExtract: Done: 0 errors, 11 filesExist, 168087580 sizeExist, 167649233 sizeExistComp, 12 filesTotal, 223926032 sizeTotal

Related branches

DipSwitch (nick-ds) on 2016-04-28
description: updated
Graham Smith (gsmitheidw) wrote :

I'm seeing similar behaviour in Debian (Jessie) with smbclient 4.3.8 and backuppc

I had a perfectly working backup system before the upgrade.

Just mentioning that here in case it helps anybody else.

Download full text (7.8 KiB)

I downgraded to samba 4.1.6 and it all works perfectly again :)
On 28 Apr 2016 20:15, "Graham Smith" <email address hidden> wrote:

> I'm seeing similar behaviour in Debian (Jessie) with smbclient 4.3.8 and
> backuppc
>
> I had a perfectly working backup system before the upgrade.
>
> Just mentioning that here in case it helps anybody else.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1576187
>
> Title:
> backuppc/smb: BackupPC failes to backup SMB shares after smbclient
> update
>
> Status in backuppc:
> Unknown
> Status in backuppc package in Ubuntu:
> New
>
> Bug description:
> After the current update of samba 4.1.6 to 4.3.8 samba on trusty the
> BackupPC smb transfer is broken.
>
> Several bugs in smbclient >= 4.1.6 in combination with BackupPC:
> https://bugzilla.samba.org/show_bug.cgi?id=11642 (tarmode is no longer
> verbose and ignores verbose flag)
> - patch1 (reenable tarmode verbose, and skip inaccessible files)
> https://attachments.samba.org/attachment.cgi?id=11733
> - patch 2 (modified clitar.c for tarmode verbose)
> https://attachments.samba.org/attachment.cgi?id=11734
> https://bugzilla.redhat.com/show_bug.cgi?id=1294761 (mis-interpreted
> failure of new tar:\d+ lines) (fix:
> https://bugzilla.redhat.com/attachment.cgi?id=1111264&action=diff)
>
> Package Information:
>
> 0)root@essrv2:~ $ dpkg -l | grep -E "(smb|samba|backuppc)"
> ii backuppc 3.3.0-1ubuntu1 amd64 high-performance, enterprise-grade
> system for backing up PCs
> ii libpam-smbpass:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 pluggable
> authentication module for Samba
> ii libsmbclient:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 shared
> library for communication with SMB/CIFS servers
> ii python-samba 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Python bindings for
> Samba
> ii samba 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 SMB/CIFS file, print, and
> login server for Unix
> ii samba-common 2:4.3.8+dfsg-0ubuntu0.14.04.2 all common files used by
> both the Samba server and client
> ii samba-common-bin 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba common
> files used by both the server and the client
> ii samba-doc 2:4.3.8+dfsg-0ubuntu0.14.04.2 all Samba documentation
> ii samba-dsdb-modules 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba
> Directory Services Database
> ii samba-libs:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba core
> libraries
> ii samba-vfs-modules 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba Virtual
> FileSystem plugins
> ii smbclient 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 command-line SMB/CIFS
> clients for Unix
>
> System information of the update:
>
> 0)root@essrv2:~ $ grep samba /var/log/apt/history.log | sed
> "s|),|)\n|g" | grep -E "(samba|smb)"
> Upgrade: libpam-smbpass:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13,
> 4.3.8+dfsg-0ubuntu0.14.04.2)
> python-samba:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13,
> 4.3.8+dfsg-0ubuntu0.14.04.2)
> samba:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
> samba-dsdb-modules:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13,
> 4.3.8+dfsg-0ubuntu0.14.04.2)
> samba-common-...

Read more...

Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in backuppc (Ubuntu):
status: New → Confirmed
Johnwolf (johnwolf159) wrote :

Well, I have this problem since April and still waiting for a fix. And since downgrading Samba seems to be a PITA, can we have an update on this bug?

Problem still happening with Samba 4.3.11

Thanks!

DipSwitch (nick-ds) wrote :
Download full text (7.6 KiB)

Can't be fixed since Samba simply doesn't output the needed data. This is
actually a Samba bug if I recall well :)

On Nov 10, 2016 04:59, "Johnwolf" <email address hidden> wrote:

Well, I have this problem since April and still waiting for a fix. And
since downgrading Samba seems to be a PITA, can we have an update on
this bug?

Problem still happening with Samba 4.3.11

Thanks!

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1576187

Title:
  backuppc/smb: BackupPC failes to backup SMB shares after smbclient
  update

Status in backuppc:
  Unknown
Status in backuppc package in Ubuntu:
  Confirmed

Bug description:
  After the current update of samba 4.1.6 to 4.3.8 samba on trusty the
  BackupPC smb transfer is broken.

  Several bugs in smbclient >= 4.1.6 in combination with BackupPC:
   https://bugzilla.samba.org/show_bug.cgi?id=11642 (tarmode is no longer
verbose and ignores verbose flag)
    - patch1 (reenable tarmode verbose, and skip inaccessible files)
https://attachments.samba.org/attachment.cgi?id=11733
    - patch 2 (modified clitar.c for tarmode verbose)
https://attachments.samba.org/attachment.cgi?id=11734
   https://bugzilla.redhat.com/show_bug.cgi?id=1294761 (mis-interpreted
failure of new tar:\d+ lines) (fix: https://bugzilla.redhat.com/
attachment.cgi?id=1111264&action=diff)

  Package Information:

   0)root@essrv2:~ $ dpkg -l | grep -E "(smb|samba|backuppc)"
   ii backuppc 3.3.0-1ubuntu1 amd64 high-performance, enterprise-grade
system for backing up PCs
   ii libpam-smbpass:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 pluggable
authentication module for Samba
   ii libsmbclient:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 shared library
for communication with SMB/CIFS servers
   ii python-samba 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Python bindings for
Samba
   ii samba 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 SMB/CIFS file, print, and
login server for Unix
   ii samba-common 2:4.3.8+dfsg-0ubuntu0.14.04.2 all common files used by
both the Samba server and client
   ii samba-common-bin 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba common
files used by both the server and the client
   ii samba-doc 2:4.3.8+dfsg-0ubuntu0.14.04.2 all Samba documentation
   ii samba-dsdb-modules 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba
Directory Services Database
   ii samba-libs:amd64 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba core
libraries
   ii samba-vfs-modules 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 Samba Virtual
FileSystem plugins
   ii smbclient 2:4.3.8+dfsg-0ubuntu0.14.04.2 amd64 command-line SMB/CIFS
clients for Unix

  System information of the update:

   0)root@essrv2:~ $ grep samba /var/log/apt/history.log | sed "s|),|)\n|g"
| grep -E "(samba|smb)"
   Upgrade: libpam-smbpass:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13,
4.3.8+dfsg-0ubuntu0.14.04.2)
    python-samba:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13,
4.3.8+dfsg-0ubuntu0.14.04.2)
    samba:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13, 4.3.8+dfsg-0ubuntu0.14.04.2)
    samba-dsdb-modules:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13,
4.3.8+dfsg-0ubuntu0.14.04.2)
    samba-common-bin:amd64 (4.1.6+dfsg-1ubuntu2.14.04.13,
4.3.8+dfsg-0ubuntu0.14.04.2)
    samba-l...

Read more...

jeltsch (michael-jeltsch) wrote :

Same problem seems to exist on Ubuntu 16.04 LTS. At least we cannot backup anything but one partial using smbclient after we upgraded from 14.04. OK, samba might be the problem. However, if we don't know whether and when this will change, then we still need a work around. After all, the backup itself kind of works...

I feel a bit embarrassed that nobody had time to look at that so far, sorry - I'm raising the prio and add some details to hope this gets done anytime soon.

OTOH upstream samba seems to refuse the chances (I comply with their reasons the bit I read into it).
That means backuppc would have to adapt.
Fortunately a recent update to the RH bug contains a patch for backuppc that seems reasonable.
=> https://bugzilla.redhat.com/attachment.cgi?id=1192784&action=diff&context=patch&collapsed=&headers=1&format=raw

The packaging of backuppc could use a rewrite *grr*, but I created a ppa version for xenial, yakkety and zesty based on that for you to verify if that approach could help to fix the issue.
=> https://launchpad.net/~paelzer/+archive/ubuntu/bug-1576187-backuppc-smbclient-tar

Please check that out and let us know.

Simon Déziel (sdeziel) wrote :

It looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820963 to me. Looking at the Debian changelog, it seems that the Ubuntu delta could be dropped at this point for Zesty.

DipSwitch (nick-ds) wrote :

Tis should be Fixed in BackupPC 3.3.2 (released today)

Changed in backuppc (Ubuntu):
status: Confirmed → Triaged
Mark - Syminet (mark-syminet) wrote :

This is still an issue in Bionic.

It has been fixed upstream in 3.3.2 (Bionic currently is 3.3.1), see last post by upstream here: https://github.com/backuppc/backuppc/issues/21

Patch is here: https://github.com/backuppc/backuppc/pull/22

Looks like smbclient output was changed, which broke some regexes in BackupPC checking for success.

Mark - Syminet (mark-syminet) wrote :

This is fixed in Bionic 18.04, however the parameter "$Conf{BackupZeroFilesIsFatal} = 0" parameter for SMB Xfer, needs to be changed for upgrading hosts that had it previously set to 1.

Relevant post at Debian bug #820693:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820963#82

Yes this change (the Debian version of it, not yours) is in since 3.3.1-3
Thanks a lot Mark! for the ping on this forgotten bug also for the documentation of the config in regard to BackupZeroFilesIsFatal if previously set to 1.

(And also thanks for your upstreaming work on this)

Changed in backuppc (Ubuntu):
status: Triaged → Fix Released
Changed in backuppc (Ubuntu Bionic):
status: New → Fix Released
tags: added: server-next
Andreas Hasenack (ahasenack) wrote :

The bionic fix came from Debian, and upstream took @mark-syminet's fix from https://github.com/backuppc/backuppc/pull/22.

Am I correct in my assumption that given upstream's fix, the Debian one isn't needed anymore?

There was one comment in the PR that hinted at problems with restoring files, but that was never further elaborated: https://github.com/backuppc/backuppc/pull/22#issuecomment-241666824

Andreas Hasenack (ahasenack) wrote :

Also, is it also correct that upstream's fix no longer needs the config change mentioned in comment #11?

Andreas Hasenack (ahasenack) wrote :

In xenial, I tested backup and a restore using the gui (restore directly on the smb server) and it worked, somewhat. The permissions were off with the restore, but that's always the case when interacting with samba from unix, and vice versa, and I believe it could be tweaked via smb.conf. I also didn't have to change any config file.

If I put this up in a ppa for xenial, can someone with more backuppc expertise give it a whirl please?

Andreas Hasenack (ahasenack) wrote :

Same fix applied to trusty, worked in the same way as xenial. Packages are building, I'll update this bug with the ppa tomorrow.

Mark - Syminet (mark-syminet) wrote :

Thanks much - once PPA is up I can try spinning up a vanilla xenial and test this week.

Andreas Hasenack (ahasenack) wrote :

This is the PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3480/

To add it: sudo add-apt-repository ppa:ci-train-ppa-service/3480

It has builds for trusty and xenial.

description: updated
description: updated
Changed in backuppc (Ubuntu Trusty):
status: New → In Progress
Changed in backuppc (Ubuntu Xenial):
status: New → In Progress
Changed in backuppc (Ubuntu Trusty):
assignee: nobody → Andreas Hasenack (ahasenack)
Changed in backuppc (Ubuntu Xenial):
assignee: nobody → Andreas Hasenack (ahasenack)
description: updated
description: updated
description: updated
Andreas Hasenack (ahasenack) wrote :

I changed the PPAs since I added dep8 tests. These are the new ones if you want to give it a whirl (the packages are still building as I write this):

trusty: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3486/
xenial: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3487/

Mark - Syminet (mark-syminet) wrote :

Tested against a win2012 server, readonly SMB share. Working here.

Andreas Hasenack (ahasenack) wrote :

Thanks Mark. This is in review at the moment, and I expect to upload these to proposed-unapproved tomorrow.

Hello DipSwitch, or anyone else affected,

Accepted backuppc into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backuppc/3.3.1-2ubuntu3.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in backuppc (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Changed in backuppc (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed-trusty
Brian Murray (brian-murray) wrote :

Hello DipSwitch, or anyone else affected,

Accepted backuppc into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backuppc/3.3.0-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.