Failed to build against 6.1.0-1036-oem, 5.15.0-43-generic

[Balaji R]

[ Impact ]

1. v6.2 commit f571faf6e443b ("timers: Provide timer_shutdown[_sync]()") was not backported to any stable trees, but it may be picked due to CVE or other reasons to oem-6.1 and generic-5.15. This, while no fixed kernel patch level for reference, can still be resolved via the configure mechanism proposed in bug 2095138.

2. The wrapped APIs, del_timer[_sync](), may also be renamed by also v6.2 commit bb663f0f3c396 ("timers: Rename del_timer() to timer_delete()"), which was backported to v6.1.84, v5.15.154, v5.10.215, and v5.4.274.

[ Test Plan ]

1. Install mainline kernel headers of following versions from https://kernel.ubuntu.com/mainline/:
   - v6.1.72
   - v5.15.155
   - v5.10.215
   - v5.4.275

2. Install all -oem/-generic kernel headers currently available in Jammy.

3. Install backport-iwlwifi-dkms from -proposed pocket of the series, or a prebuilt one from https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/experimental-dkms.

4. The dkms should be compiled automatically with the running kernel. To compile it against all the installed kernels:

```
$ for k in $(dpkg -l| awk '$2 ~ /^linux-headers-.*-(generic)|(oem)$/ { print substr($2, length("linux-headers-") + 1); }'|sort -V -r); do sudo dkms install --force backport-iwlwifi/0~93.12955-gite723a6f0 -k $k || break; done
```

[ Where problems could occur ]

The adaption layer was done to provide API compatibility with previously released kernels. The upstream change may be depending on some implicitly related fixes, but it doesn't seem to be the case for this update. What we have here are compile problems.

[ Other Info ]

Only nominate for Plucky and Jammy because the related timer API issues fall in kernel versions supported by Jammy and Focal. For Focal, not sure if that's worthy of fixing at this moment.

This is being SRU-ed along with bug 2095138. See debdiffs in https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/2095138/comments/10.

========== original bug report ==========

I'm experiencing no wifi driver found issue.
My system details:
Network controller: Intel Corporation Alder Lake-P PCH CNVi WiFi (rev 01)

ProblemType: Package
DistroRelease: Ubuntu 22.04
Package: backport-iwlwifi-dkms 11510-0ubuntu1~22.04.1
ProcVersionSignature: Ubuntu 5.15.0-43.46-generic 5.15.39
Uname: Linux 5.15.0-43-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.6
Architecture: amd64
CasperMD5CheckResult: pass
Date: Wed Oct 2 12:44:15 2024
ErrorMessage: installed backport-iwlwifi-dkms package post-installation script subprocess returned error exit status 10
InstallationDate: Installed on 2024-10-02 (0 days ago)
InstallationMedia: Ubuntu 22.04.1 LTS "Jammy Jellyfish" - Release amd64 (20220809.1)
PackageArchitecture: all
Python3Details: /usr/bin/python3.10, Python 3.10.12, python3-minimal, 3.10.6-1~22.04.1
PythonDetails: N/A
RelatedPackageVersions:
 dpkg 1.21.1ubuntu2.3
 apt 2.4.13
SourcePackage: backport-iwlwifi-dkms
Title: package backport-iwlwifi-dkms 11510-0ubuntu1~22.04.1 failed to install/upgrade: installed backport-iwlwifi-dkms package post-installation script subprocess returned error exit status 10
UpgradeStatus: Upgraded to jammy on 2024-10-02 (0 days ago)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[You-Sheng Yang (vicamo)]

There is no more linux-headers of version 5.15.0-43.46-generic
available, use -72 for testing instead.

So this should have been fixed by bug 2069582, but it did not notice
that it's also affecting outdated kernel headers versions. The problem
should have gone away since -93, and the latest -135 is also healthy.

[You-Sheng Yang (vicamo)]

This is failing 6.1.0-1036-oem as well.

[You-Sheng Yang (vicamo)]

1. v6.2 commit f571faf6e443b ("timers: Provide timer_shutdown[_sync]()") was not backported to any stable trees, but it may be picked due to CVE or other reasons to oem-6.1 and generic-5.15. This, while no fixed kernel patch level for reference, can still be resolved via the configure mechanism proposed in bug 2095138.

2. The wrapped APIs, del_timer[_sync](), may also be renamed by also v6.2 commit bb663f0f3c396 ("timers: Rename del_timer() to timer_delete()"), which was backported to v6.1.84, v5.15.154, v5.10.215, and v5.4.274.

[You-Sheng Yang (vicamo)]

This is being SRU-ed along with bug 2095138. See debdiffs in https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/2095138/comments/10.

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 1:0~93.12955-gite723a6f0-0ubuntu1

---------------
backport-iwlwifi-dkms (1:0~93.12955-gite723a6f0-0ubuntu1) plucky; urgency=medium

  [You-Sheng Yang]

  * Migrate to upstream core93 release (LP: #2098677)
    - Drop upstreamed patches
      0015-backports-tree-wide-finally-take-no_llseek-out.patch and
      0016-backports-netdev_features-convert-NETIF_F_NETNS_LOCA.patch
    - debian: dkms: bump OBSOLETE_BY to 6.14

  * Failed to build against v6.13 (LP: #2095140)
    - d/p/backport-drop-use-of-pcim_iomap_regions_request_all.patch
    - d/p/backports-pcie-fixes-for-PCI-mappings.patch
    - d/p/backports-convert-symbol-namespace-names-to-string-l.patch

  * Failed to build against linux-6.14: error: implicit declaration of
    function 'debugfs_rename'; did you mean 'debugfs_remove'? (LP: #2098687)
    - d/p/backports-accommodate-to-API-rename-of-debugfs_rename.patch

  * Failed to build against linux-generic 6.8 with stable backports
    (LP: #2095138)
    - sync genlmsg_multicast_allns impl. a bit from upstream
    - d/p/configure-add-m4-macros-for-kernel-feature-detection.patch
    - d/p/configure-add-basic-files-for-build-time-configure.patch
    - d/p/configure-detect-genlmsg_multicast_allns-ABI.patch
    - debian: update rules/control/install/... to support files for build
      time configure script.

  * Failed to build against 6.1.0-1036-oem, 5.15.0-43-generic (LP: #2083481)
    - d/p/configure-detect-timer_shutdown-_sync-API.patch
    - d/p/backports-timers-Rename-del_timer-_sync.patch
    - d/p/configure-detect-timer_delete_sync-API.patch

  * Accumulative fixes for build failures against previous stable kernel
    releases (LP: #2095143)
    - d/p/backports-make-sure-KUNIT_STATIC_STUB_REDIRECT-is-de.patch
    - d/p/backports-include-linux-slab.h-for-kvmalloc.patch
    - d/p/backports-remove-include-linux-min-max.h.patch
    - d/p/backports-correct-version-range-for-dma-mapping-help.patch
    - d/p/backports-correct-version-range-for-scatterlist-help.patch
    - d/p/backports-include-linux-kernel.h-before-linux-overflow.h.patch

 -- You-Sheng Yang <email address hidden> Mon, 17 Feb 2025 22:43:58 +0800

[Timo Aaltonen (tjaalton)]

Hello Balaji, or anyone else affected,

Accepted backport-iwlwifi-dkms into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/11510-0ubuntu1~22.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[You-Sheng Yang (vicamo)]

verified backport-iwlwifi-dkms/jammy-proposed version 11510-0ubuntu1~22.04.3 against all oem/generic kernels.

[Andreas Hasenack (ahasenack)]

I don't think there is anything left to sponsor here, therefore I'm unsubscribing ubuntu-sponsors.