backport-iwlwifi-dkms FTBS with linux 6.5 on jammy

[Andrea Righi]

[Impact]

/var/lib/dkms/backport-iwlwifi/9858/build/drivers/net/wireless/intel/iwlwifi/mvm/tx.c:845:16: error: implicit declaration of function ‘skb_gso_segment’; did you mean ‘skb_gso_reset’? [-Werror=implicit-function-declaration]
  845 | next = skb_gso_segment(skb, netdev_flags);
      | ^~~~~~~~~~~~~~~
      | skb_gso_reset

[Test case]

 $ sudo apt install backport-iwlwifi-dkms

[Fix]

Backport form mantic the required changes to support the new linux 6.5 kernel ABI.

[Regression potential]

We may experience regressions in systems that are still relying on the iwlwifi driver.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: backport-iwlwifi-dkms 9858-0ubuntu3.3
ProcVersionSignature: User Name 6.5.0-9.9~22.04.2-generic 6.5.3
Uname: Linux 6.5.0-9-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Thu Oct 26 13:11:55 2023
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: backport-iwlwifi-dkms
UpgradeStatus: No upgrade log present (probably fresh install)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "backport-iwlwifi-dkms-support-linux-6.5-jammy.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted backport-iwlwifi-dkms into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/9858-0ubuntu3.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[You-Sheng Yang (vicamo)]

verified backport-iwlwifi-dkms/jammy-proposed version 9858-0ubuntu3.4 against linux-oem-6.5/jammy version 6.5.0-1006.6.

[Andreas Hasenack (ahasenack)]

This bug does not mention the status of this package in lunar, mantic, or noble. This should have been made clear in the description or in the bug tasks, whether they are affected or not.

Tip: slide 33 of https://events.canonical.com/event/31/contributions/250/attachments/134/212/The%20(im)perfect%20SRU.pdf :)

Since the fix mentions a backport from mantic, I presume it's fixed there, but I had to be sure, so I went ahead and tested it in mantic and all the others.

Upon installing backport-iwlwifi-dkms, no build errors. There were a bunch of messages about a module being obsoleted because it's already included in 6.5.0, but others were built.

Lunar: apparently no 6.5 kernel for lunar, not even in the kernel team's ppa. Is it that lunar will never get a 6.5 kernel? I presume so.

Noble:
kernel 6.5.0, package installs and builds modules just fine.

Given the above, I'm addind the appropriate tasks and statuses to the bug.

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 9858-0ubuntu3.4

---------------
backport-iwlwifi-dkms (9858-0ubuntu3.4) jammy; urgency=medium

  * Support linux 6.5 (LP: #2041171):
    - debian/patches/0030-support-linux-6.5.patch

 -- Andrea Righi <email address hidden> Thu, 26 Oct 2023 13:07:28 +0000

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.