backport-iwlwifi-dkms/8324-0ubuntu3~20.04.3 ADT test failure with linux-hwe-5.11/5.11.0-20.21~20.04.1

[Kleber Sacilotto de Souza]

[SRU Justification]

[Impact]

backport-iwlwifi-dkms/8324-0ubuntu3~20.04.3 ADT test failure with linux-hwe-5.11/5.11.0-20.21~20.04.1.

[Fix]

In Focal, we have been disabling installing of built DKMS binary modules since bug 1863583. While it's unlikely we may backport newest version to Focal due to the size of changes for SRU, and for the availability of rolling kernel policy we have, it's becoming more and more irrelevant to install this package as the in-tree modules should always be more up-to-date.

Therefore the proposed solution to this ADT test failure will be to disable DKMS build completely.

[Test Case]

Install this package and it should skip binary module compiling.

[Where problems could occur]

The binary modules built from this dkms package have been inactive for a while. No additional effect applies to the running system, except for adt testing.

[Other Info]
While we have newer revisions in Groovy/Hirsute and Impish, such disablement doesn't applies to other series.

========== original bug report ==========

This is a scripted bug report about ADT failures while running backport-iwlwifi-dkms tests for linux-hwe-5.11/5.11.0-20.21~20.04.1 on focal. Whether this is caused by the dep8 tests of the tested source or the kernel has yet to be determined.

Testing failed on:
    amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/b/backport-iwlwifi-dkms/20210611_210250_6ee22@/log.gz
    arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/b/backport-iwlwifi-dkms/20210612_122231_02f9a@/log.gz
    ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/b/backport-iwlwifi-dkms/20210611_210211_ec4a1@/log.gz

[Other]

NB! dkms ftbfs fixes must be built in security, such that after SRU process in -proposed & -updates it can be copied into -security pocket too.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[You-Sheng Yang (vicamo)]

PPA: https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1932158

[You-Sheng Yang (vicamo)]

Since we have rolling kernel releases via -hwe flavor in LTS, the necessity of maintaining a working iwlwifi dkms package is becoming more and more irrelevant over time. backport-iwlwifi-dkms has been marked obsoleted for kernel v5.4 and newer, so we're going to take a step further to disable the build completely here.

Latest backport-iwlwifi-dkms is still available in devel series. See bug 1929180.

[Łukasz Zemczak (sil2100)]

Just a confirmation, since the debian/changelog entry is a bit misleading: this should be disabled for the 5.4 kernel as well, right? Since the regex clearly only accepts kernels to up to 5.3. I suppose that's the plan, right? Because changelog mentions 'newer than 5.4' not 'newer or equal to 5.4'.

[You-Sheng Yang (vicamo)]

Hi, yes, we don't need this for kernel >= 5.4.0.

[Brian Murray (brian-murray)]

Hello Kleber, or anyone else affected,

Accepted backport-iwlwifi-dkms into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/8324-0ubuntu3~20.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted backport-iwlwifi-dkms (8324-0ubuntu3~20.04.4) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

backport-iwlwifi-dkms/8324-0ubuntu3~20.04.4 (amd64, ppc64el, arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#backport-iwlwifi-dkms

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[You-Sheng Yang (vicamo)]

Verified version 8324-0ubuntu3~20.04.4 from focal-proposed:

$ dpkg -l|grep linux-h | awk '{print $1" "$2"\t"$3}'
ii linux-headers-5.10.0-1037-oem 5.10.0-1037.38
ii linux-headers-5.11.0-24-generic 5.11.0-24.25~20.04.1
ii linux-headers-5.13.0-1007-oem 5.13.0-1007.7
ii linux-headers-5.4.0-79 5.4.0-79.88
ii linux-headers-5.4.0-79-generic 5.4.0-79.88
ii linux-headers-5.6.0-1057-oem 5.6.0-1057.61
ii linux-headers-5.8.0-61-generic 5.8.0-61.68~20.04.1
ii linux-headers-generic 5.4.0.79.82
ii linux-headers-generic-hwe-20.04 5.8.0.61.68~20.04.44
ii linux-headers-generic-hwe-20.04-edge 5.11.0.24.25~20.04.8
ii linux-headers-oem-20.04b 5.10.0.1037.38
ii linux-headers-oem-20.04c 5.13.0.1007.7
ii linux-hwe-5.11-headers-5.11.0-24 5.11.0-24.25~20.04.1
ii linux-hwe-5.8-headers-5.8.0-61 5.8.0-61.68~20.04.1

$ dkms status
backport-iwlwifi, 8324: added

[Dimitri John Ledkov (xnox)]

Building initial module for 5.4.0-77-generic
Error! The /var/lib/dkms/backport-iwlwifi/8324/5.4.0-77-generic/aarch64/dkms.conf for module backport-iwlwifi includes a BUILD_EXCLUSIVE directive which
does not match this kernel/arch. This indicates that it should not be built.
Skipped.
Processing triggers for man-db (2.9.1-1) ...
Processing triggers for libc-bin (2.31-0ubuntu9.2) ...
tar: Cowardly refusing to create an empty archive
Try 'tar --help' or 'tar --usage' for more information.
autopkgtest [23:10:51]: test dkms-autopkgtest: -----------------------]
dkms-autopkgtest FAIL non-zero exit status 123
autopkgtest [23:10:53]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
autopkgtest [23:10:54]: @@@@@@@@@@@@@@@@@@@@ summary
dkms-autopkgtest FAIL non-zero exit status 123
Creating nova instance adt-focal-arm64-backport-iwlwifi-dkms-20210713-230659 from image adt/ubuntu-focal-arm64-server-20210713.img (UUID 125ff749-0127-4cb7-aaed-4711ace45625)...

autopkgtest seems to not able to handle well the fact that this dkms module exists but it is not being built.

I'm now pondering if we should remove it from the archive and/or replace it with an empty deb.

Also I guess we need to adjust dkms-autopkgtest to be able to handle skipped dkms modules, and return SKIP in this case.

[Dimitri John Ledkov (xnox)]

Opened https://bugs.launchpad.net/ubuntu/+source/dkms/+bug/1936344 to make dkms autopkgtest smarter.

[You-Sheng Yang (vicamo)]

The dkms-autopkgtest carried in backport-iwlwifi-dkms (and other dkms modules supported XB-Modaliases) was forked from that of dkms package. So the fix should still belong to backport-iwlwifi-dkms.

I'm testing two methods:

1. https://gitlab.com/echoii/dkms/backport-iwlwifi-dkms/-/jobs/1434542781: accommodate dkms-autopkgtest script in backport-iwlwifi-dkms to zero built modules,

2. https://gitlab.com/echoii/dkms/backport-iwlwifi-dkms/-/jobs/1435230556: switch to dkms-autopkgtest from dkms package.

The latter seems the right method to take in the long term, but I'd still like to support XB-Modaliases for that's heavily used in OEM projects. By heavily, there is actually nearly no DKMS package being used. rtl9921ce should be one.

I think we can fix this in Focal first, and go on to sale XB-Modaliases support to the dkms upstream project, and fix everything right.

[You-Sheng Yang (vicamo)]

Tested in https://gitlab.com/echoii/dkms/backport-iwlwifi-dkms/-/pipelines/339390713

[Dimitri John Ledkov (xnox)]

Changes in #15 are not suitable to go into Focal yet. As they should first be present in impish as well. Otherwise, whilst Focal switches to dkms package provider testing harness, the Impish package did not.

[Dimitri John Ledkov (xnox)]

@vicamo sponsoring #15 to impish. Please apply the debdiff from here to impish packaging git.

[Dimitri John Ledkov (xnox)]

The proposed change fails in ADT in impish, please investigate

https://autopkgtest.ubuntu.com/packages/b/backport-iwlwifi-dkms

[You-Sheng Yang (vicamo)]

Testing:
* focal: https://gitlab.com/echoii/dkms/backport-iwlwifi-dkms/-/jobs/1444857128
* hirsute: https://gitlab.com/echoii/dkms/backport-iwlwifi-dkms/-/jobs/1444827356
* impish: https://gitlab.com/echoii/dkms/backport-iwlwifi-dkms/-/jobs/1444740462

[You-Sheng Yang (vicamo)]

All autopkgtests passed. Please help landing.

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 9340-0ubuntu4

---------------
backport-iwlwifi-dkms (9340-0ubuntu4) impish; urgency=medium

  * Bump OBSOLETE_BY from v5.4 to v5.14, as this is a much newer snapshot
    than stuff that has shipped in v5.13. LP: #1932158

backport-iwlwifi-dkms (9340-0ubuntu3) impish; urgency=medium

  * Switch to dkms-autopkgtest from dkms package. (LP: #1932158)

backport-iwlwifi-dkms (9340-0ubuntu1) impish; urgency=low

  * New release
    - upstream version 9340 commit c5c6a05cf2b59e. (LP: #1929180)

  * ci: avoid duplicated pipelines

  * debian/patches:
    - update 0005-Makefile.kernel-pass-fno-stack-clash-protection-and-.patch
    - drop 0006-backport-address-interface-change-in-linux-skbuff.h-.patch
    - drop 0007-backport-netlink-remove-NLA_EXACT_LEN_WARN.patch
    - drop 0008-Linux-5.10-redefine-kzfree-as-kfree_sensitive.patch
    - drop 0009-Linux-5.10-use-NLA_POLICY_MIN_LEN.patch

 -- Dimitri John Ledkov <email address hidden> Thu, 29 Jul 2021 15:47:52 +0100

[Łukasz Zemczak (sil2100)]

Looks like this isn't actually Incomplete in focal anymore. Releasing.

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 8324-0ubuntu3~20.04.4

---------------
backport-iwlwifi-dkms (8324-0ubuntu3~20.04.4) focal; urgency=medium

  * Disable build against kernel newer than v5.4. (LP: #1932158)

 -- You-Sheng Yang <email address hidden> Wed, 23 Jun 2021 17:26:41 +0800

[Chris Halse Rogers (raof)]

An upload of backport-iwlwifi-dkms to focal-proposed has been rejected from the upload queue for the following reason: "Steve's question from 2022-05-07 on LP: #1962704 remains unanswered; rejecting from the queue in the hope that this either prompts someone to look at the bug, or that no-one cares about this anymore. Also: several of the bugs referenced in the changelog have subsequently been marked as Fix Released for focal, and don't seem to correspond to what the changelog describes as fixing anymore.".