[FFe] Please sync ayatana-indicator-power 2.0.93-1 from Debian Sid

[Simon Quigley]

I wear my Ubuntu Developer hat here.

ayatana-indicator-power 2.0.93-1, which was uploaded to Debian today, is worth getting in Ubuntu for the LTS release, in my opinion. It seems to me like it is a borderline bugfix release, but it does add new functions which I consider new features.

Specifically, looking at the upstream diff between the version in bionic-proposed and in Sid: https://github.com/AyatanaIndicators/ayatana-indicator-power/compare/2.0.92...2.0.93

Here are the commits which I believe break Feature Freeze:
 - src/utils.(c|h): Port is_{mate,gnome,unity}() functions from -session indicator. - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/1830c84a2b95ca4b840a65317e75a609b33c3512
 - src/service.c: Use desktop detection functions in 'on_statistics_activated()' - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/60363ad00518bf0d4b85ddc74e407a8ed0cbcb83
 - src/utils.c: Add is_pantheon() function. - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/2026ee0ea8ea662c7fa9cef0d3a1bc043212f542
 - src/utils.c: Use our desktop detection functions for find a way to open an appropriate power settings dialog. - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/32df70ed9a55a9ec66c1689a007df9714bee16f5
 - Add fallback code that produces a warning (using zenity), if we don't know how to handle certain actions. - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/9819c2ee11af87fe567a2438e072dfd08774bb3d
 - Use gmock module from cmake-extras. - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/970f3823f1c14e094630e63d8d9b79235cb9bacf
 - Use coverage support from cmake-extras. - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/744720d0a29eb327aa0c25b4f3c4c134eb78e855
 - Use intltool support from cmake-extras. - https://github.com/AyatanaIndicators/ayatana-indicator-power/commit/59f9f20e6bd7a9b261a0600aa69acb8c26c52cc4

I say that these fixes are borderline bugfix because while they do not seem to actively fix a problem, they simply the code a bit. Specifically, the two major changes are adding separate functions for desktop environment detection and converting to cmake-extras for some modules.

These are enhancements which I believe to be trivial enough as to not disrupt the package or the archive.

Thanks.

[Simon Quigley (tsimonq2)]

I have subscribed the authors of these commits should anybody have any questions.

[Mike Gabriel (sunweaver)]

I (Debian maintainer) just uploaded 2.0.93-1 fixing co-installability of ayatana-indicator-power and indicator-power.

See https://github.com/AyatanaIndicators/ayatana-indicator-power/issues/1

[Mike Gabriel (sunweaver)]

Sorry, the correct / new version is 2.0.93-2.

[Łukasz Zemczak (sil2100)]

A few things I would like to know before proceeding:

1) Has this new upstream version been already tested on a bionic machine through a PPA? What functional tests have been performed?

2) Seeing that the previous version that's in bionic-proposed (2.0.92-1) FTBFS on armhf and arm64, could you provide some build logs from a test build (PPA?), making sure it now builds correctly on all supported architectures?

3) Even though the changes are borderline FF-acceptable, just wanted to confirm if there is any hard rationale to have this still for bionic? Is any of the aforementioned commits critical for any of the supported flavours? It's not that such solid rationale is required, just want to know if by any chance there is a specific need for it or just 'nice to have the latest version'.

Thanks!

[Mike Gabriel (sunweaver)]

1) yes, functionality-wise by Martin Wimpress (local build, I presume), I myself test-built in a bionic sbuild chroot

2) unfortunately, I see build failures on Debian for 2.0.93-2, as well, but for a different reason (something severly broken in /usr/bin/gdbus-codegen, totally unrelated to the package it seems):
https://buildd.debian.org/status/package.php?p=ayatana-indicator-power

I have a request pending on #debian-buildds to investigate the cause of the new FTBFS symptoms.

The previous version in unstable 2.0.93-1 built successfully on all archs supported by Debian.

3) Esp. the change in 2.0.93-2 (enum id name changes in the gschema file to allow co-installability with indicator-power) should give good reason (so that people can start playing with Arctica Greeter that uses/recommends ayatana-indicator-power.

The FTBFS fixes (due to parallelism problems in the test suite) have been RC in Debian, so probably that applies to Ubuntu, too.

The rest of the changes (desktop env gnostics) are more for the future than relevant for the 18.04 release.

[Łukasz Zemczak (sil2100)]

@sunweaver Could you perform a test build in an Ubuntu PPA with armhf and arm64 enabled and report back if the package builds correctly in Ubuntu on all arches (with logs)? I think once we have certainty that the new version does no longer FTBFS, I'd be glad to approve the FFe.

[Mike Gabriel (sunweaver)]

Hi,

On Mi 04 Apr 2018 18:08:15 CEST, Łukasz Zemczak wrote:

> @sunweaver Could you perform a test build in an Ubuntu PPA with armhf
> and arm64 enabled and report back if the package builds correctly in
> Ubuntu on all arches (with logs)? I think once we have certainty that
> the new version does no longer FTBFS, I'd be glad to approve the FFe.

I have now uploaded the source package to:

https://launchpad.net/~sunweaver/+archive/ubuntu/ppa

Builds against all Ubuntu architectures are currently running.

Mike
--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: [phone]
landline: [phone]

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
mail: <email address hidden>, http://das-netzwerkteam.de