indicator-messages-service crashed with SIGSEGV in g_type_check_instance() from g_signal_handlers_disconnect_matched() from act_user_manager_finalize() from g_object_unref() from im_accounts_service_dispose()

[errors.ubuntu.com bug bridge]

The Ubuntu Error Tracker has been receiving reports about a problem regarding indicator-messages. This problem was most recently seen with package version 13.10.1+18.10.20180918-0ubuntu3, the problem page at https://errors.ubuntu.com/problem/94c77bb11d79da78a8cb610adb9252f41d2ab4a4 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

[Sebastien Bacher (seb128)]

Is that still an issue with https://bugs.launchpad.net/ubuntu/+source/accountsservice/22.08.8-1ubuntu6 ?

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Daniel van Vugt (vanvugt)]

Yes the latest 3 crashes are from 22.08.8-1ubuntu6

[Sebastien Bacher (seb128)]

That's the version installed on disk but are we confident they restarted their session to have that version of the library loaded by the indicator?

[Daniel van Vugt (vanvugt)]

That was published 4 days ago, but we'll have a better idea in a week if bug 2015962 isn't the #6 crash in all of lunar anymore: https://errors.ubuntu.com/?release=Ubuntu%2023.04&period=week

[Daniel van Vugt (vanvugt)]

I just got another one in bug 2015982 with libaccountsservice0 22.08.8-1ubuntu6 (after several reboots) so let's see what that retraces to.

[Daniel van Vugt (vanvugt)]

Yes confirmed still happening in bug 2015982 with libaccountsservice0 22.08.8-1ubuntu6

[Daniel van Vugt (vanvugt)]

This crash happens on logout, BTW.

[Sebastien Bacher (seb128)]

Confirmed, the issue is also still there using accountsservices master, I've reported it upstream with a valgrind log now

https://gitlab.freedesktop.org/accountsservice/accountsservice/-/issues/113

[Launchpad Janitor (janitor)]

This bug was fixed in the package accountsservice - 22.08.8-1ubuntu7

---------------
accountsservice (22.08.8-1ubuntu7) lunar; urgency=medium

  * debian/patches/gitlab_manager_requests.patch:
    - Disconnect from manager signals when freeing a request and resolve
      indicator-messages crashing on logout, thanks Marco! (lp: #2015962)

 -- Sebastien Bacher <email address hidden> Thu, 13 Apr 2023 23:59:56 +0200

[Daniel van Vugt (vanvugt)]

Still crashing in accountsservice 22.08.8-1ubuntu7:

https://errors.ubuntu.com/problem/94c77bb11d79da78a8cb610adb9252f41d2ab4a4

[Sebastien Bacher (seb128)]

Could you confirm that those loaded the new library version? Because I confirmed locally that the segfault and valgrind error were fixed with the new release, at least in the testcase described upstream (but could be that the issue referred to is different from the one reported/triggered by the testcase)

[Gunnar Hjalmarsson (gunnarhj)]

Since im_accounts_service_dispose() is mentioned in the bug title, can this possibly have something to do with bug #2015610?

[Daniel van Vugt (vanvugt)]

I reboot every day and just got this:

  Apr 18 14:48 _usr_lib_x86_64-linux-gnu_indicator-messages_indicator-messages-service.1000.crash

with

  accountsservice 22.08.8-1ubuntu7

but I'm still working on a retrace.

[Sebastien Bacher (seb128)]

@Daniel, do you have the indicator loaded in GNOME or is an Unity/other desktop session?

[Daniel van Vugt (vanvugt)]

I don't use indicators ever, on any machine. It's just that indicator-messages-service crashes on logout.

[Daniel van Vugt (vanvugt)]

ubuntu-bug/apport refuse to upload my crash and local debugging even with debuginfod is missing symbols!? But it still looks like the same bug:

Program terminated with signal SIGSEGV, Segmentation fault.
#0 g_type_check_instance (type_instance=0x555588f84fd0)
    at ../../../gobject/gtype.c:4272
#1 0x00007f2d17daf568 in g_signal_handlers_disconnect_matched
    (instance=0x555588f84fd0, mask=(G_SIGNAL_MATCH_FUNC | G_SIGNAL_MATCH_DATA), signal_id=0, detail=0, closure=0x0, func=0x7f2d17c1ed70, data=0x555588f88760)
    at ../../../gobject/gsignal.c:3067
#2 0x00007f2d17c189a8 in () at /lib/x86_64-linux-gnu/libaccountsservice.so.0
#3 0x00007f2d17da5e4c in g_object_unref (_object=0x555588f88760)
    at ../../../gobject/gobject.c:3938

[Daniel van Vugt (vanvugt)]

^^^
accountsservice was upgraded to 22.08.8-1ubuntu7 on 2023-04-14 and the machine was rebooted every day between then and 2023-04-18 before it crashed again. So definitely 22.08.8-1ubuntu7

[Daniel van Vugt (vanvugt)]

I just rebooted for a second time today and reproduced the crash again with libaccountsservice0 22.08.8-1ubuntu7

Program terminated with signal SIGSEGV, Segmentation fault.

#0 g_type_check_instance (type_instance=0x55b49b114970)
    at ../../../gobject/gtype.c:4272
#1 0x00007f94d743a568 in g_signal_handlers_disconnect_matched (
    instance=instance@entry=0x55b49b114970,
    mask=mask@entry=(G_SIGNAL_MATCH_FUNC | G_SIGNAL_MATCH_DATA),
    signal_id=signal_id@entry=0, detail=detail@entry=0,
    closure=closure@entry=0x0,
    func=func@entry=0x7f94d72a9d70 <on_new_user_loaded>, data=0x55b49b1151b0)
    at ../../../gobject/gsignal.c:3067
#2 0x00007f94d72a39a8 in act_user_manager_finalize (object=0x55b49b1151b0)
    at ../src/libaccountsservice/act-user-manager.c:2639
#3 0x00007f94d7430e4c in g_object_unref (_object=0x55b49b1151b0)
    at ../../../gobject/gobject.c:3938
#4 0x000055b499c9b950 in im_accounts_service_dispose (object=0x55b49b114020)
    at ./src/im-accounts-service.c:84
#5 0x00007f94d7430da0 in g_object_unref (_object=0x55b49b114020)
    at ../../../gobject/gobject.c:3891
#6 0x000055b499c9ac04 in im_application_list_dispose (object=0x55b49b110e10)
    at ./src/im-application-list.c:566
#7 0x00007f94d7430da0 in g_object_unref (_object=0x55b49b110e10)
    at ../../../gobject/gobject.c:3891
#8 0x000055b499c9a41e in main (argc=<optimised out>, argv=0x7fff96920ea8)
    at ./src/messages-service.c:289

[Rudra Saraswat (rs2009)]

I can confirm I'm facing the same issue in the latest Ubuntu Unity daily build (with the latest version of accountsservice).

indicator-messages crashes on every login, not just on log out (including booting the ISO). You should be able to reproduce this bug with the latest Ubuntu Unity ISO at https://cdimage.ubuntu.com/ubuntu-unity/daily-live/current.

[Daniel van Vugt (vanvugt)]

You mean you get presented with the error report dialog on login, from the crash of the previous logout :)

[Rudra Saraswat (rs2009)]

vanvugt: nope, also when booting the live ISO for the first time (so I can confirm it's not just at logouts; trying to get a stack trace, but network's really unstable today, so unable to download debug symbols)

[Sebastien Bacher (seb128)]

Reported upstream with a valgrind log on https://gitlab.freedesktop.org/accountsservice/accountsservice/-/issues/114

[Łukasz Zemczak (sil2100)]

I accepted indicator-messages into lunar-proposed but, sadly, it didn't build. The issue is on the binary-package level:

https://launchpad.net/ubuntu/+source/indicator-messages/13.10.1+18.10.20180918-0ubuntu4

Basically what's happening is that indicator-messages and ayatana-indicator-messages both build the libmessaging-menu* binary packages. This is not right. Both are available in the archive for lunar. So indicator-messages cannot be published as it tries to upload the new binaries but it sees newer versioned ones (from ayatana) already - and bails.

We probably need to drop the libmessaging-menu* packages from indicator-messages.

[Sebastien Bacher (seb128)]

Going forward we need to remove indicator-messages and use the ayatana one which is maintained and switch the flavors to use that one but removing those binaries for the build for now would probably make sense yes

[Andreas Hasenack (ahasenack)]

Summarizing this bug from an SRU POV

We need https://launchpad.net/ubuntu/+source/indicator-messages/13.10.1+18.10.20180918-0ubuntu5 in lunar. Previous upload of 0ubuntu4 failed to migrate/build (see comment #24), and I guess 0ubuntu5 arrived too late for the release.

We also have https://launchpad.net/ubuntu/lunar/+upload/31007427/+files/ayatana-indicator-messages_22.9.0-1ubuntu1_source.changes in lunar-unapproved

I'm sensing both need to land in lunar-proposed at the same time for this bug to be fixed in lunar?

And what about accountsservice 22.08.8-1ubuntu7, which is in lunar already, but its task in this bug is "fix committed"? I saw there was some back and forth with it, and it sounded it would have the fix for this bug, but then didn't. Is it still related to this bug, or can we remove/delete its task? Or move it to "fix released"?

[Sebastien Bacher (seb128)]

@Andreas

Replying about the accountsservice part, we got some issues resolved there before the release but the bug here is a different problem then the one addressed in accountsservice 22.08.8-1ubuntu7.

The issue is in the indicator codebase and the right fix is what has been uploaded for (ayatana-)indicator-messages recently but Marco also worked on making accountsservice more robust to such coding errors. The fix has been commited upstream now but not uploaded to Ubuntu yet (we tend to use 'fix commited' on desktop component for things which have a fix available in the upstream vcs which can be slightly confusing)

[Steve Langasek (vorlon)]

This bug report is lacking required information for an SRU.

[Łukasz Zemczak (sil2100)]

We have decided this is a zero-day SRU, we already tested it and we'll release it as-is.

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-messages - 13.10.1+18.10.20180918-0ubuntu5

---------------
indicator-messages (13.10.1+18.10.20180918-0ubuntu5) lunar; urgency=medium

  * debian/conrol, debian/*.install: drop the libmessaging-menu0,
    libmessaging-menu-dev and gir1.2-messagingmenu-1.0 binary packages. Those
    are built and provided by ayatana-indicator-messages and cannot
    realistically be published to the archive during builds right now. They
    have been removed from the archive already when copied-forward.
  * debian/rules: change --fail-missing to --list-missing so that we don't
    fail when we don't install all the built files. Remove unneeded removal
    of *.la files as we don't install the library bits anymore.
  * debian/rules: make sure dh_auto_install does what it's supposed to.

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 19 Apr 2023 16:55:12 +0100

[Chris Halse Rogers (raof)]

An upload of ayatana-indicator-messages to lunar-proposed has been rejected from the upload queue for the following reason: "Rejecting from the queue as this is still missing SRU information, and that should notify someone who cares :). The diff itself looks fine, although the it now also needs fixing in mantic and the lunar upload needs a non-conflicting version number. Please feel free to reupload with those fixed.".

[Launchpad Janitor (janitor)]

This bug was fixed in the package accountsservice - 23.13.9-2ubuntu1

---------------
accountsservice (23.13.9-2ubuntu1) mantic; urgency=medium

  * Includes some extra upstream bugfixes

accountsservice (23.13.9-2) unstable; urgency=medium

  * debian/patches/git_user_manager.patch:
    - Disconnect from manager signals when freeing a request and resolve
      indicator-messages crashing on logout (lp: #2015962)
  * debian/patches/git_default_gdm.patch:
    - default to gdm if there display-manager.service isn't a known target,
      which is the case for our gdm called gdm3, fixes the service
      crashing when trying to toggle autologin (lp: #2024870)

 -- Sebastien Bacher <email address hidden> Mon, 26 Jun 2023 16:25:07 +0200