syntax error in /usr/share/awstats/tools/buildstatic.sh

Bug #707365 reported by Kenyon Ralph on 2011-01-25
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
awstats (Debian)
Fix Released
Unknown
awstats (Ubuntu)
Low
James Page
Maverick
Low
Unassigned

Bug Description

IMPACT:
awstats users on Maverick are not be able to build static HTML reports from awstats data. This normally runs automatically overnight.

FIX:
Amend minor bashism in buildstatic.sh (Debian/Ubuntu specific script)
   The == needs to be a = on line 27.

TEST CASE:
Run buildstatic.sh pre-fix:
   [: 27: yes: unexpected operator
Run buildstatic.sh post-fix:
   Runs cleanly

REGRESSION POTENTIAL:
This script is currently not functional in Maverick so regression potential is limited.

== ORIGINAL BUG REPORT ==

Binary package hint: awstats

[: 27: yes: unexpected operator

The == needs to be a = on line 27.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: awstats 6.9.5~dfsg-3ubuntu0.1
ProcVersionSignature: Ubuntu 2.6.35-25.43-generic 2.6.35.10
Uname: Linux 2.6.35-25-generic i686
Architecture: i386
Date: Tue Jan 25 03:48:17 2011
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/sh
SourcePackage: awstats

Related branches

Kenyon Ralph (kralph) wrote :
James Page (james-page) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. Please answer these questions:

* Is this reproducible?
* If so, what specific steps should we take to recreate this bug?

This will help us to find and resolve the problem.

Changed in awstats (Ubuntu):
status: New → Incomplete
Kenyon Ralph (kralph) wrote :

Yes, this is reproducible. Remove the extra equals sign, and the syntax becomes correct, and the script runs without error. Add the equals sign, and see a syntax error on execution.

This is a Bourne shell script. See the dash(1) manual page; there is no == operator for test expressions.

Changed in awstats (Ubuntu):
status: Incomplete → New
James Page (james-page) wrote :

Already fixed in later releases from Debian (see linked bug) so fixed for Natty; suggest as this is really low impact that an SRU for maverick is appropriate.

Changed in awstats (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → James Page (james-page)
James Page (james-page) on 2011-01-27
description: updated
description: updated
description: updated
James Page (james-page) on 2011-01-27
Changed in awstats (Ubuntu):
milestone: none → maverick-updates
milestone: maverick-updates → none
status: Confirmed → In Progress
importance: Low → Medium
importance: Medium → Low
James Page (james-page) wrote :

Not present in Lucid; this script was introduced in 6.9.5~dfsg-1 which post-dates this release.

Changed in awstats (Ubuntu Maverick):
importance: Undecided → Low
status: New → In Progress
Martin Pitt (pitti) wrote :

Comment 4 says this is fixed in natty.

Changed in awstats (Ubuntu):
status: In Progress → Fix Released
Changed in awstats (Ubuntu Maverick):
status: In Progress → Fix Committed
tags: added: verification-needed

Accepted awstats into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Kenyon Ralph (kralph) wrote :

I successfully executed the corrected script from 6.9.5~dfsg-3ubuntu0.2 in maverick-proposed.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package awstats - 6.9.5~dfsg-3ubuntu0.2

---------------
awstats (6.9.5~dfsg-3ubuntu0.2) maverick-proposed; urgency=low

  * Fix bashism in buildstatic.sh (LP: #707365)
 -- James Page <email address hidden> Thu, 27 Jan 2011 15:03:47 +0000

Changed in awstats (Ubuntu Maverick):
status: Fix Committed → Fix Released
Changed in awstats (Debian):
status: Unknown → Fix Released
tags: added: testcase
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.