tap method of Touch device doesn't have press_duration arg

Bug #1268782 reported by Leo Arias
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Autopilot
Fix Released
Undecided
Leo Arias
autopilot (Ubuntu)
New
Undecided
Unassigned
Vivid
New
Undecided
Unassigned

Bug Description

Currently it's not possible to do a long press on the phone, for example in order to show the popover of the text fields.

Tags: elopio

Related branches

Revision history for this message
Leo Arias (elopio) wrote :

The fix is easy, in _uinput.Touch.tap, add an argument press_duration=0.1, and pass it to the sleep between finger_down and finger_up. Then, also pass it on Pointer.click to the Touch backend.

What's hard is the test for it. I think it wouldn't be correct to just check the value send to sleep. We need to check the amount of time elapsed between the _finger_down and _finger_up.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Hmm, this would be better in autopilot itself instead of the emulator or an app test suite (thus being reimplemented again and again)

Revision history for this message
Leo Arias (elopio) wrote :

Yes, I have some branches that will make it easy to test, and then I'll be able to fix it.

Changed in autopilot:
assignee: nobody → Leo Arias (elopio)
Leo Arias (elopio)
Changed in autopilot:
status: New → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:autopilot at revision None, scheduled for release in autopilot, milestone 1.4

Changed in autopilot:
status: In Progress → Fix Committed
Changed in autopilot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.