augeas-lenses filter for PHP files doesn't match php7.0-* files

Bug #1580731 reported by Simon Arlott on 2016-05-11
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
augeas (Ubuntu)
Medium
Unassigned
Xenial
Medium
Raphaël Pinson

Bug Description

The filter list in /usr/share/augeas/lenses/dist/php.aug includes:
/etc/php*/*/*.ini
/etc/php*/fpm/pool.d/*.conf

This will match the php5-fpm package files:
/etc/php5/fpm/php.ini
/etc/php5/fpm/pool.d/*.conf

But not the php7.0-fpm package files:
/etc/php/7.0/fpm/php.ini
/etc/php/7.0/fpm/pool.d/*.conf

Puppet handles this badly because augeas won't report that anything has changed trying to set options in /etc/php/7.0/fpm/php.ini, so it does nothing instead of reporting an error:

Debug: Augeas[php_sessions](provider=augeas): Will attempt to save and only run if files changed
Debug: Augeas[php_sessions](provider=augeas): sending command 'set' with params ["/files/etc/php/7.0/fpm/php.ini/Session/session.gc_maxlifetime", "604800"]
Debug: Augeas[php_sessions](provider=augeas): Skipping because no files were changed
Debug: Augeas[php_sessions](provider=augeas): Closed the augeas connection

augeas-lenses:
  Installed: 1.4.0-0ubuntu1
  Candidate: 1.4.0-0ubuntu1
  Version table:
 *** 1.4.0-0ubuntu1 500
        500 http://gb.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
        500 http://gb.archive.ubuntu.com/ubuntu xenial/main i386 Packages
        100 /var/lib/dpkg/status

php7.0-fpm:
  Installed: 7.0.4-7ubuntu2ppa1
  Candidate: 7.0.4-7ubuntu2ppa1
  Version table:
 *** 7.0.4-7ubuntu2ppa1 1000
       1000 http://ppa.launchpad.net/sa.me.uk/um/ubuntu xenial/main amd64 Packages
        100 /var/lib/dpkg/status
     7.0.4-7ubuntu2 500
        500 http://gb.archive.ubuntu.com/ubuntu xenial/universe amd64 Packages

Simon Arlott (sa.me.uk) on 2016-05-11
affects: ubuntu → augeas (Ubuntu)
Robie Basak (racb) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better.

I believe upstream monitor bugs for this package. I'm interested to know how upstream plan to fix this - we can cherry-pick their changes.

Changed in augeas (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
tags: added: needs-upstream-report
Dominic Cleal (domcleal) wrote :

I'd suggest just adding these two entries to the includes list:

/etc/php/*/*/*.ini
/etc/php/*/fpm/pool.d/*.conf

Unless there are other incompatible INI files that might be matched? I'm not familiar with the PHP packages to be sure.

Michael Wodniok (wodniok) wrote :

Okay, i've opened a pull request for this some hours ago and it got already accepted (upstream-Bug #399: https://github.com/hercules-team/augeas/commit/d454d7dceb2613b861db6d2a8724bf47360466f7

Raphaël Pinson (raphink) wrote :

I could add this patch to the augeas 1.6 package in Yakkety. Do we want to include it in Xenial, too though?

Michael Wodniok (wodniok) wrote :

... and the rest of my comment went away, thx launchpad ...

it contains only the first line, as i didn't know fpm was also affected (not using it).
Please make sure the line fixes the problem for fpm. If yes, please either make a PR, or say something, then i will create a second one.

The other question is, whether this package is still maintained (another bug is still there, but patch exists and is posted here).

Michael Wodniok (wodniok) wrote :

@raphink: yes, please.

Robie Basak (racb) on 2016-08-18
tags: added: server-next
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package augeas - 1.6.0-0ubuntu2

---------------
augeas (1.6.0-0ubuntu2) yakkety; urgency=medium

  * Fix location of php.ini for PHP 7 (LP: #1580731):
    - d/p/0004-Reflect-Ubuntu-16.04-location-of-php.ini-399.patch

 -- Raphaël Pinson <email address hidden> Thu, 18 Aug 2016 16:17:27 +0200

Changed in augeas (Ubuntu):
status: Triaged → Fix Released
Robie Basak (racb) wrote :

Thanks Raphaël! I'll add a task for Xenial.

Changed in augeas (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → Medium
tags: added: bitesize
removed: needs-upstream-report
Robie Basak (racb) on 2016-08-30
Changed in augeas (Ubuntu Xenial):
assignee: nobody → Jon Grimm (jgrimm)
Jon Grimm (jgrimm) on 2016-09-01
Changed in augeas (Ubuntu Xenial):
assignee: Jon Grimm (jgrimm) → Raphaël Pinson (raphink)
Jon Grimm (jgrimm) wrote :

@raphink (or anyone else that has seen this)

I built a xenial ppa with this fix. Would you be able to test, or provide a set of instructions that would allow me to test the fix?

https://launchpad.net/~jgrimm/+archive/ubuntu/augeas-1580731

sudo add-apt-repository ppa:jgrimm/augeas-1580731
sudo apt-get update

Assuming the fix tests well, I'll work an SRU for 16.04/xenial.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers