attr/xattr.h conflicts with new glibc sys/xattr.h

[Martin Pitt]

Latest eglibc changed its <sys/xattr.h> file to define XATTR_CREATE as a enum:

{
  XATTR_CREATE = 1,……………/* set value, fail if attr already exists. */
#define XATTR_CREATE…………XATTR_CREATE
  XATTR_REPLACE = 2……………/* set value, fail if attr does not exist. */
#define XATTR_REPLACE………XATTR_REPLACE
};

But our <attr/xattr.h> conflicts to that as it defines it as a macro:

#define XATTR_CREATE 0x1 /* set value, fail if attr already exists */
#define XATTR_REPLACE 0x2 /* set value, fail if attr does not exist */

This leads to build failures like in systemd, which explicitly inclue <attr/xattr.h>, but <sys/xattr.h> gets pulled in through some other include:

In file included from src/core/socket.c:33:0:
/usr/include/x86_64-linux-gnu/sys/xattr.h:31:3: error: expected identifier before numeric constant
   XATTR_CREATE = 1, /* set value, fail if attr already exists. */

See https://launchpad.net/ubuntu/+source/systemd/204-5ubuntu12 for the build errror, and https://sourceware.org/ml/libc-alpha/2014-01/msg00075.html for an upstream discussion about that.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Camilo Aguilar (camilo-aguilar)]

I just got bitten by this issue. Is there any workaround while a fix gets worked out?

[Martin Pitt (pitti)]

Camilo, we use this in systemd:
http://anonscm.debian.org/gitweb/?p=pkg-systemd/systemd.git;a=blob;f=debian/patches/Fix-FTBFS-against-recent-kernels-glibc.patch;h=b6ce7e33a596d4fd4262a7da9c049489e2bc1efb;hb=refs/heads/ubuntu

[Sebastian Geiger (lanoxx)]

Is there any fix for this? It prevents me from building systemd...

[Martin Pitt (pitti)]

Lanoxx, this got fixed in systemd: http://cgit.freedesktop.org/systemd/systemd/commit/?id=d2edfae0f9b