at-spi2-registryd.conf upstart script missing closing ']'

[Haw Loeung]

Impact
At-spi2 does run, but the missing closing bracket in the upstart config file may be causing the gsettings check to fail. In addition, the following is shown in the user's local upstart logs for at-spi2-registryd:

/proc/self/fd/9: 2: [: missing ]

Regression potential:
Little to none at all given that this was a typo.

Test case:
1. Install the new at-spi2-core package from saucy-proposed.
2. Remove the at-spi2-core upstart log from ~/.cache/upstart.
3. Log out and back in.
4. The below error should not be present in the at-spi2-core upstart log.

Hi,

I'm seeing a bunch of missing ']' errors in ~/.cache/upstart/at-spi2-registryd.log. It seems this is because the 'pre-start' stanza is missing a closing ']' as shown below:

pre-start script
    [ "$(gsettings get org.gnome.desktop.interface toolkit-accessibility)" \
         = "true" || exit 0
end script

It seems like an easy fix but I can't seem to find which LP branch to create a merge proposal against.

Regards,

Haw
---
ApportVersion: 2.12.5-0ubuntu1
Architecture: amd64
DistroRelease: Ubuntu 13.10
MarkForUpload: True
Package: at-spi2-core 2.10.0-0ubuntu2 [modified: usr/share/upstart/sessions/at-spi2-registryd.conf]
PackageArchitecture: amd64
ProcVersionSignature: Ubuntu 3.11.0-11.17-generic 3.11.3
Tags: saucy
Uname: Linux 3.11.0-11-generic x86_64
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm admin audio cdrom dialout libvirtd lpadmin netdev plugdev sambashare users video
modified.conffile..etc.xdg.autostart.at.spi.dbus.bus.desktop: [modified]
mtime.conffile..etc.xdg.autostart.at.spi.dbus.bus.desktop: 2013-07-24T01:24:45.829666

[Haw Loeung (hloeung)]

apport information

[Haw Loeung (hloeung)]

apport information

[Haw Loeung (hloeung)]

https://launchpadlibrarian.net/152758649/at-spi2-core_2.10.0-0ubuntu2_2.10.0-0ubuntu2~ppa.diff.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package at-spi2-core - 2.10.1-0ubuntu1

---------------
at-spi2-core (2.10.1-0ubuntu1) trusty; urgency=low

  * New upstream bugfix release (LP: #1241308)
    - Fix a leak introduced in 2.9.92 that adversely affected performance
      (BGO#709625).
  * debian/patches/revert-message-flow-optimization.patch: Drop, properly
    fixed upstream.
  * Add missing closing bracket to upstart file (LP: #1236346)
  * debian/patches/fix_crash.patch:
    - Fix crash in register_client (LP: #1037357)
 -- Luke Yelavich <email address hidden> Fri, 25 Oct 2013 08:58:55 +1100

[Brian Murray (brian-murray)]

Although rather obvious this bug is missing an official test case.

[Brian Murray (brian-murray)]

Hello Haw, or anyone else affected,

Accepted at-spi2-core into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/at-spi2-core/2.10.1-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Haw Loeung (hloeung)]

Hi,

at-spi2-core_2.10.1-0ubuntu0.1 fixes this for me.

Thanks,

Haw

[Launchpad Janitor (janitor)]

This bug was fixed in the package at-spi2-core - 2.10.1-0ubuntu0.1

---------------
at-spi2-core (2.10.1-0ubuntu0.1) saucy; urgency=low

  * New upstream bugfix release (LP: #1241308)
    - Fix a leak introduced in 2.9.92 that adversely affected performance
      (BGO#709625).
  * debian/patches/revert-message-flow-optimization.patch: Drop, properly
    fixed upstream.
  * Add missing closing bracket to upstart file (LP: #1236346)
  * debian/patches/fix_crash.patch:
    - Fix crash in register_client (LP: #1037357)
 -- Luke Yelavich <email address hidden> Fri, 25 Oct 2013 13:17:42 +1100

[Brian Murray (brian-murray)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.