ubuntu patch 04_changelog broken, ill-defined scope, out-of-date

Bug #1053792 reported by Daniel Hartwig on 2012-09-21
0
Affects Status Importance Assigned to Milestone
aptitude (Ubuntu)
Undecided
Unassigned

Bug Description

ubuntu patch 04_changelog

This change is completely broken:

--- a/src/apt_options.cc
+++ b/src/apt_options.cc
- "http://cgi.debian.org/cgi-bin/get-changelog?package=%s"),
+ "http://changelogs.ubuntu.com/changelogs/pool/%s/%s/%s/%s_%s/changelog"),

It changes the meaning of the template parameter and introduces new parameters. There is nowhere in the patch where the consumer of this template is updated. The combination of these two points is bad, very bad, but ok in this case–by default–as the template in question has not been used since ancient history. None-the-less, the above change is absolutely wrong: should the use of this template be re-introduced Ubuntu users are at-risk of having broken values for it in their custom configuration.

Remove that change.

The patch also includes changes to interface strings which overlap the scope of 03_branding. Please move those changes there and keep 04_changelog exclusive to modifying which server is used.

--
Package: aptitude
Version: 0.6.8ubuntu1

Simon Quigley (tsimonq2) wrote :

Is this bug still valid?

I am asking because this is dates 2012...

Simon Quigley (tsimonq2) wrote :

*ated

Simon Quigley (tsimonq2) wrote :

*dated :P

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers