dialog to resolve config file conflicts can be only one line high

Bug #1689668 reported by Brian Murray on 2017-05-09
This bug affects 7 people
Affects Status Importance Assigned to Milestone
aptdaemon (Ubuntu)
Brian Murray
Brian Murray

Bug Description

The config file conflict dialog in update-manager will be only one line high. This essentially just shows the start of the diff making it hard for people to make an informed decision.

[Test Case]
1) Install artful (so you have updates to install)
2) Modify /etc/update-manager/release-upgrades and set Prompt=never
3) Edi /var/lib/dpkg/status and set the md5sum for /etc/update-manager/release-upgrades to something else e.g. use the md5sum for meta-release
4) Run update-manager (only install the software updater group)
5) Observe the config file prompt dialog being 1 line high

With the version of aptdaemon from -proposed you will see multiple lines.

[Regression Potential]
Little - its a one line patch to to allow the dialog to expand vertically.

Original Description

This is similar to bug 1623856 regarding the download progress window only being one line high but the dialog affected is actually the one that says:

        title = _("Replace your changes in '%s' with a later version of "
                  "the configuration file?") % from_path
        msg = _("If you don't know why the file is there already, it is "
                "usually safe to replace it.")

I've observed this on Ubuntu 17.04 but suspect it also affects Ubuntu 16.10 as the other bug does.

  Installed: 1.1.1+bzr982-0ubuntu17
  Candidate: 1.1.1+bzr982-0ubuntu17
  Version table:
 *** 1.1.1+bzr982-0ubuntu17 500
        500 zesty/main amd64 Packages

Brian Murray (brian-murray) wrote :
Brian Murray (brian-murray) wrote :

Perhaps this should have been fixed in the following class:

class _DetailsExpanderMessageDialog(_ExpandableDialog):
    Common base class for Apt*Dialog

tags: added: rls-aa-incoming
Steve Langasek (vorlon) on 2017-07-27
Changed in aptdaemon (Ubuntu):
importance: Undecided → High
tags: removed: rls-aa-incoming
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in aptdaemon (Ubuntu):
status: New → Confirmed
Changed in aptdaemon (Ubuntu Artful):
assignee: nobody → Brian Murray (brian-murray)
tags: added: id-597a0a32ed7a7da4a899a20b
Changed in aptdaemon (Ubuntu):
status: Confirmed → Fix Committed
tags: added: id-5a95f346db833635da0cf63b
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package aptdaemon - 1.1.1+bzr982-0ubuntu19

aptdaemon (1.1.1+bzr982-0ubuntu19) bionic; urgency=medium

  * d/p/lp1690541-details-open-twice.patch: Indicate that the AptTerminal
    widget would like extra space so we can see more terminal output.
    (LP: #1690541)

 -- Brian Murray <email address hidden> Tue, 27 Feb 2018 16:21:11 -0800

Changed in aptdaemon (Ubuntu):
status: Fix Committed → Fix Released
description: updated
description: updated
Changed in aptdaemon (Ubuntu Artful):
status: Confirmed → In Progress

Hello Brian, or anyone else affected,

Accepted aptdaemon into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/aptdaemon/1.1.1+bzr982-0ubuntu17.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in aptdaemon (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-artful
Brian Murray (brian-murray) wrote :

I installed the version of aptdaemon from -proposed and confirm that this works.

bdmurray@clean-artful-amd64:~$ sudo apt-get install aptdaemon
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  python3-aptdaemon python3-aptdaemon.gtk3widgets
The following packages will be upgraded:
  aptdaemon python3-aptdaemon python3-aptdaemon.gtk3widgets
3 upgraded, 0 newly installed, 0 to remove and 162 not upgraded.
Need to get 105 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 artful-proposed/main amd64 python3-aptdaemon.gtk3widgets all 1.1.1+bzr982-0ubuntu17.1 [13.9 kB]
Get:2 artful-proposed/main amd64 aptdaemon all 1.1.1+bzr982-0ubuntu17.1 [13.5 kB]
Get:3 artful-proposed/main amd64 python3-aptdaemon all 1.1.1+bzr982-0ubuntu17.1 [77.1 kB]
Fetched 105 kB in 0s (0 B/s)

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package aptdaemon - 1.1.1+bzr982-0ubuntu17.1

aptdaemon (1.1.1+bzr982-0ubuntu17.1) artful; urgency=medium

  * d/p/lp1689668-config-file-window.patch: Ensure that the dialog to resolve
    config conflicts is large enough to provide useful information.
    (LP: #1689668)
  * d/p/lp1690541-details-open-twice.patch: Indicate that the AptTerminal
    widget would like extra space so we can see more terminal output.
    (LP: #1690541)

 -- Brian Murray <email address hidden> Tue, 27 Feb 2018 08:43:10 -0800

Changed in aptdaemon (Ubuntu Artful):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for aptdaemon has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers