| 2021-04-28 12:49:39 |
Julian Andres Klode |
bug |
|
|
added bug |
| 2021-04-28 12:49:52 |
Julian Andres Klode |
bug task added |
|
python-apt (Ubuntu) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Hirsute |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Hirsute) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
python-apt (Ubuntu Hirsute) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Impish |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Impish) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
python-apt (Ubuntu Impish) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Xenial |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Xenial) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
python-apt (Ubuntu Xenial) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Bionic |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Bionic) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
python-apt (Ubuntu Bionic) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Groovy |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Groovy) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
python-apt (Ubuntu Groovy) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Focal |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Focal) |
|
| 2021-04-28 12:50:02 |
Julian Andres Klode |
bug task added |
|
python-apt (Ubuntu Focal) |
|
| 2021-04-28 12:50:13 |
Julian Andres Klode |
bug task deleted |
apt (Ubuntu Bionic) |
|
|
| 2021-04-28 12:50:20 |
Julian Andres Klode |
bug task deleted |
apt (Ubuntu Focal) |
|
|
| 2021-04-28 12:50:47 |
Julian Andres Klode |
bug task deleted |
apt (Ubuntu Groovy) |
|
|
| 2021-04-28 12:50:54 |
Julian Andres Klode |
bug task deleted |
apt (Ubuntu Hirsute) |
|
|
| 2021-04-28 12:50:59 |
Julian Andres Klode |
bug task deleted |
apt (Ubuntu Impish) |
|
|
| 2021-04-28 12:51:11 |
Julian Andres Klode |
apt (Ubuntu): status |
New |
Invalid |
|
| 2021-04-28 13:06:22 |
Balint Reczey |
bug |
|
|
added subscriber Balint Reczey |
| 2021-04-28 20:23:17 |
Brian Murray |
apt (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2021-04-28 20:23:21 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-04-28 20:23:24 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2021-04-28 20:23:29 |
Brian Murray |
tags |
|
verification-needed verification-needed-xenial |
|
| 2021-04-29 13:22:49 |
Julian Andres Klode |
description |
[Impact]
APT in xenial needs to learn about zstd support to enable Launchpad to work with zstd packages.
python-apt in all releases needs to be adjusted to pass the compressor names instead of programs to ExtractTar, as otherwise, if /usr/bin/zstd does not exist, it will pass "false" as the compressor, and then ExtractTar fails (same for other compressors).
[Test plan]
The apt regression tests cover the compression methods extensively, including even stored compressed lists in /var/lib/apt and fetching Packages files compressed with such methods, for all compression methods.
The final test is to make apt_inst.DebFile("glibc-doc-reference_2.33-0ubuntu2~zstd1_all.deb").control.extractall() from 1923845 work in python3-apt.
[Where problems could occur]
APT:
The changes to APT are adding the zstd compression backend to FileFd and then linking it into the configuration. The former is adding new code, triggered only on zstd files, and should not be able to cause regressions.
The latter is a bunch of small lines here and there, and it caused issues during backporting in the test suite because it expected compressors in a specific order. However, chances are that nothing else has as stringent requirements as the test suite, so I don't believe that is a problem for existing users.
Bugs can of course be in the code dealing with zstd, and that might open you up to security vulnerabilities in the zstd code if you pass APT zstd compressed files.
A regression can be if clients used apt-helper cat-file to cat a zstd-compressed file ending in .zst - they'll now get uncompressed content, rather than compressed.
python-apt:
The change just replaces Binary with Name, aligning the code with APT itself, so it's so trivial, we don't expect regressions. |
[Impact]
APT in xenial needs to learn about zstd support to enable Launchpad to work with zstd packages.
python-apt in all releases needs to be adjusted to pass the compressor names instead of programs to ExtractTar, as otherwise, if /usr/bin/zstd does not exist, it will pass "false" as the compressor, and then ExtractTar fails (same for other compressors).
On hirsute, the python-apt upload also includes some new <!nocheck> annotations for build-dependencies, as it's a straight upload of the 2.2
stable series.
[Test plan]
The apt regression tests cover the compression methods extensively, including even stored compressed lists in /var/lib/apt and fetching Packages files compressed with such methods, for all compression methods.
The final test is to make apt_inst.DebFile("glibc-doc-reference_2.33-0ubuntu2~zstd1_all.deb").control.extractall() from 1923845 work in python3-apt.
For hirsute, the build dependency changes will verify themselves during the build ;)
[Where problems could occur]
APT:
The changes to APT are adding the zstd compression backend to FileFd and then linking it into the configuration. The former is adding new code, triggered only on zstd files, and should not be able to cause regressions.
The latter is a bunch of small lines here and there, and it caused issues during backporting in the test suite because it expected compressors in a specific order. However, chances are that nothing else has as stringent requirements as the test suite, so I don't believe that is a problem for existing users.
Bugs can of course be in the code dealing with zstd, and that might open you up to security vulnerabilities in the zstd code if you pass APT zstd compressed files.
A regression can be if clients used apt-helper cat-file to cat a zstd-compressed file ending in .zst - they'll now get uncompressed content, rather than compressed.
python-apt:
The change just replaces Binary with Name, aligning the code with APT itself, so it's so trivial, we don't expect regressions. |
|
| 2021-04-29 19:20:19 |
Julian Andres Klode |
tags |
verification-needed verification-needed-xenial |
verification-done verification-done-xenial |
|
| 2021-04-29 20:03:33 |
Launchpad Janitor |
apt (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2021-04-29 20:03:44 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-05-02 03:12:54 |
Mathew Hodson |
apt (Ubuntu): status |
Invalid |
Fix Released |
|
| 2021-05-10 08:50:04 |
Łukasz Zemczak |
python-apt (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2021-05-10 08:55:55 |
Łukasz Zemczak |
python-apt (Ubuntu Hirsute): status |
New |
Fix Committed |
|
| 2021-05-10 08:55:57 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-05-10 08:56:03 |
Łukasz Zemczak |
tags |
verification-done verification-done-xenial |
verification-done-xenial verification-needed verification-needed-hirsute |
|
| 2021-05-10 11:24:35 |
Łukasz Zemczak |
python-apt (Ubuntu Groovy): status |
New |
Fix Committed |
|
| 2021-05-10 11:24:39 |
Łukasz Zemczak |
tags |
verification-done-xenial verification-needed verification-needed-hirsute |
verification-done-xenial verification-needed verification-needed-groovy verification-needed-hirsute |
|
| 2021-05-10 11:35:28 |
Łukasz Zemczak |
python-apt (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2021-05-10 11:35:34 |
Łukasz Zemczak |
tags |
verification-done-xenial verification-needed verification-needed-groovy verification-needed-hirsute |
verification-done-xenial verification-needed verification-needed-focal verification-needed-groovy verification-needed-hirsute |
|
| 2021-05-10 11:37:19 |
Łukasz Zemczak |
python-apt (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2021-05-10 11:37:25 |
Łukasz Zemczak |
tags |
verification-done-xenial verification-needed verification-needed-focal verification-needed-groovy verification-needed-hirsute |
verification-done-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy verification-needed-hirsute |
|
| 2021-05-11 14:16:11 |
Launchpad Janitor |
python-apt (Ubuntu Impish): status |
New |
Fix Released |
|
| 2021-05-13 20:00:42 |
Balint Reczey |
tags |
verification-done-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy verification-needed-hirsute |
verification-done verification-done-bionic verification-done-focal verification-done-groovy verification-done-hirsute verification-done-xenial |
|
| 2021-05-17 22:49:46 |
Launchpad Janitor |
python-apt (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
| 2021-06-01 20:04:47 |
Launchpad Janitor |
python-apt (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2021-06-01 20:05:25 |
Launchpad Janitor |
python-apt (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2021-06-02 15:30:27 |
Launchpad Janitor |
python-apt (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-06-03 17:54:17 |
Launchpad Janitor |
python-apt (Ubuntu Groovy): status |
Fix Committed |
Fix Released |
|
