http:Fix Host header in proxied https connections

Bug #1838771 reported by Eric Desrochers on 2019-08-02
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apt (Ubuntu)
Medium
Unassigned
Bionic
Medium
Julian Andres Klode
Disco
Medium
Julian Andres Klode

Bug Description

[Impact]

Currently CONNECT requests use the name of the proxy as Host value, instead of the origin server's name.

According to RFC 2616 "The Host field value MUST represent the naming authority of the origin server or gateway given by the original URL."

The current implementation causes problems with some proxy vendors. This
commit[0] fixes this.

[0] - https://salsa.debian.org/apt-team/apt/commit/86d4d98060f36c7e71c34af20a1193a75496ef72#54d3193c5d10a0032c80c3a6d3f069507265547f

[Test Case]

Here's one reproducer an impacted user brought to my attention:

# /etc/environment
http_proxy="http://internal:8080"
https_proxy="http://interal:8080"

To support application development activities in-house, I had to configure Azure CLI APT repository following the instructions from "https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-apt?view=azure-cli-latest":

$ sudo apt-get update
$ sudo apt-get install curl apt-transport-https lsb-release gnupg
$ curl -sL https://packages.microsoft.com/keys/microsoft.asc | \
$ gpg --dearmor | \
$ sudo tee /etc/apt/trusted.gpg.d/microsoft.asc.gpg > /dev/null
$ AZ_REPO=$(lsb_release -cs)
$ echo "deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ $ $ AZ_REPO main" | \
$ sudo tee /etc/apt/sources.list.d/azure-cli.list
$ sudo apt update

In the final "apt update" command, APT respects system-wide network proxy variables and successfully fetched Canonical repository data over HTTP.

However, it was unable to fetch the newly added Microsoft packages repository served via HTTPS.

By using Wireshark to examine the HTTPS request made by APT, the request body reveals as:

CONNECT packages.microsoft.com:443 HTTP/1.1\r\n
Host: internal:8080\r\n
User-Agent: Debian APT-HTTP/1.3 (1.6.11)\r\n
...
...

There also is an automated test case in the package that runs as part of autopkgtest that tests a scenario like this, see the commit.

[Regression Potential]

* Fix already in debian, and Eoan
* Has been reviewed/approved by juliank
* A test package (pre-sru) has been provided to an impacted user, and he confirms it solves the situation.

[Other Info]

# salsa
$ git describe --contains 86d4d98060f36c7e71c34af20a1193a75496ef72
1.9.0~8

# rmadison apt
=> apt | 1.6.11 | bionic-updates | source, amd64, arm64, armhf, i386, ppc64el, s390x
=> apt | 1.8.1 | disco-updates | source, amd64, arm64, armhf, i386, ppc64el, s390x
apt | 1.9.1 | eoan | source, amd64, arm64, armhf, i386, ppc64el, s390x

Eric Desrochers (slashd) on 2019-08-02
Changed in apt (Ubuntu):
status: New → Fix Released
tags: added: sts
Changed in apt (Ubuntu Bionic):
assignee: nobody → Eric Desrochers (slashd)
Changed in apt (Ubuntu Disco):
assignee: nobody → Eric Desrochers (slashd)
status: New → In Progress
Changed in apt (Ubuntu Bionic):
status: New → In Progress
Eric Desrochers (slashd) on 2019-08-05
description: updated
Eric Desrochers (slashd) on 2019-08-05
description: updated
Eric Desrochers (slashd) on 2019-08-05
Changed in apt (Ubuntu Bionic):
importance: Undecided → Medium
Changed in apt (Ubuntu Disco):
importance: Undecided → Medium
Eric Desrochers (slashd) on 2019-08-05
Changed in apt (Ubuntu Bionic):
assignee: Eric Desrochers (slashd) → nobody
assignee: nobody → Julian Andres Klode (juliank)
Changed in apt (Ubuntu Disco):
assignee: Eric Desrochers (slashd) → Julian Andres Klode (juliank)
Julian Andres Klode (juliank) wrote :

Uploaded apt 1.8.3 to disco (this is a sync (*) from Debian unstable, and also includes some other bug fixes from 1.8.2 which I forgot to sync earlier)

(*) uploaded with --no-lp so we get a diff for sru-review

description: updated

Hello Eric, or anyone else affected,

Accepted apt into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.8.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in apt (Ubuntu Disco):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-disco

All autopkgtests for the newly accepted apt (1.8.3) for disco have finished running.
The following regressions have been reported in tests triggered by the package:

auto-apt-proxy/11 (armhf)
reprotest/0.7.8 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/disco/update_excuses.html#apt

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Hello Eric, or anyone else affected,

Accepted apt into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.6.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in apt (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic

All autopkgtests for the newly accepted apt (1.6.12) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

sbuild/0.75.0-1ubuntu1 (ppc64el)
apport/2.20.9-0ubuntu7.7 (amd64, i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#apt

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Changed in apt (Ubuntu):
importance: Undecided → Medium
Julian Andres Klode (juliank) wrote :

The included autopkgtest the verifies this fix has passed for both 1.8.3 and 1.6.12

(221/256) Testcase test-proxy-connect: P P P P P P P P P P P P P P

The two apport autopkgtest failures for 1.6.12 for bionic remain, they seem to be the usual launchpad timeout/unavailable issue.

tags: added: verification-done verification-done-bionic verification-done-disco
removed: verification-needed verification-needed-bionic verification-needed-disco
Łukasz Zemczak (sil2100) wrote :

Eric, could you check the package and make sure the fix works as expected for you as well?

Eric Desrochers (slashd) wrote :

[VERIFICATION BIONIC]

It looks good to me testing with the above [Test Case].

# apt-get update
Hit:1 http://security.ubuntu.com/ubuntu bionic-security InRelease
==> Hit:2 https://packages.microsoft.com/repos/azure-cli bionic InRelease
Hit:3 http://archive.ubuntu.com/ubuntu bionic InRelease
Hit:4 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
Hit:5 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
Hit:6 http://archive.ubuntu.com/ubuntu bionic-proposed InRelease
Reading package lists... Done

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apt - 1.8.3

---------------
apt (1.8.3) unstable; urgency=medium

  [ Simon Körner ]
  * http: Fix Host header in proxied https connections (LP: #1838771)

  [ Brian Murray ]
  * Do not include squashfs file systems in df output. (LP: #1756595)

apt (1.8.2) unstable; urgency=medium

  [ Alwin Henseler ]
  * Flip /: in documented default value of DPkg::Path (Closes: #917986)

  [ TilmanK ]
  * Fix typo in German manpage translation

  [ Américo Monteiro ]
  * Portuguese manpages translation update (Closes: #926614)

  [ Jean-Pierre Giraud ]
  * French manpages translation update (Closes: #929290)

  [ Michael Zhivich ]
  * methods: https: handle requests for TLS re-handshake (LP: #1829861)

  [ Julian Andres Klode ]
  * Unlock dpkg locks in reverse locking order (LP: #1829860)

 -- Julian Andres Klode <email address hidden> Fri, 09 Aug 2019 11:16:15 +0200

Changed in apt (Ubuntu Disco):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for apt has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apt - 1.6.12

---------------
apt (1.6.12) bionic; urgency=medium

  [ TilmanK ]
  * Fix typo in German manpage translation

  [ Michael Zhivich ]
  * methods: https: handle requests for TLS re-handshake (LP: #1829861)

  [ Julian Andres Klode ]
  * Unlock dpkg locks in reverse locking order (LP: #1829860)

  [ Simon Körner ]
  * http: Fix Host header in proxied https connections (LP: #1838771)

  [ Brian Murray ]
  * Do not include squashfs file systems in df output. (LP: #1756595)

 -- Julian Andres Klode <email address hidden> Tue, 03 Sep 2019 12:05:35 +0200

Changed in apt (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers