pkgCacheFile unlocks in destructor even if it did not acquire lock

Bug #1794053 reported by Julian Andres Klode on 2018-09-24
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apt (Ubuntu)
Status tracked in Cosmic
Trusty
High
Unassigned
Xenial
High
Unassigned
Bionic
High
Unassigned
Cosmic
High
Julian Andres Klode

Bug Description

[Impact]
Closing a cache file unlocks the system (loses the lock). This randomly breaks ubuntu-make, for example.

[Test case]
The following Python code fails, but should succeed, as it locks first, opens a cache and closes it, and then unlocks.

import apt_pkg, os, gc

apt_pkg.init()
apt_pkg.pkgsystem_lock()

os.system("ls -l /proc/%d/fd" % os.getpid())
apt_pkg.Cache()

gc.collect()

os.system("ls -l /proc/%d/fd" % os.getpid())

apt_pkg.pkgsystem_unlock()

[Regression potential]
This fixes a regression introduced in 2001 by

commit b2e465d6d32d2dc884f58b94acb7e35f671a87fe
Author: Arch Librarian <email address hidden>
Date: Mon Sep 20 16:56:32 2004 +0000

    Join with aliencode
    Author: jgg
    Date: 2001-02-20 07:03:16 GMT
    Join with aliencode

The fix is to only UnLock from the cache file if the cache file locked before. It's unclear how far code relies on that regression. That said, any potential regression should be easily noticable, as it would be a case of not unlocking where we were unlocking before.

Changed in apt (Ubuntu):
importance: Undecided → High
status: New → In Progress
assignee: nobody → Julian Andres Klode (juliank)
Changed in apt (Ubuntu Bionic):
importance: Undecided → High
Changed in apt (Ubuntu Xenial):
importance: Undecided → High
Changed in apt (Ubuntu Trusty):
importance: Undecided → High
status: New → Triaged
Changed in apt (Ubuntu Xenial):
status: New → Triaged
Changed in apt (Ubuntu Bionic):
status: New → Triaged
Changed in apt (Ubuntu Cosmic):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apt - 1.7.0~rc2ubuntu1

---------------
apt (1.7.0~rc2ubuntu1) cosmic; urgency=medium

  * Fix calculation of elapsed usec in downloads
  * pkgCacheFile: Only unlock in destructor if locked before (LP: #1794053)

 -- Julian Andres Klode <email address hidden> Mon, 24 Sep 2018 12:18:26 +0200

Changed in apt (Ubuntu Cosmic):
status: Fix Committed → Fix Released

Hello Julian, or anyone else affected,

Accepted apt into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.6.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in apt (Ubuntu Bionic):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-bionic
Łukasz Zemczak (sil2100) wrote :

Hello Julian, or anyone else affected,

Accepted apt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.2.28 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in apt (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed-xenial
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers