Add linux-modules* packages to VersionedKernelPackages

[Seth Forshee]

== SRU Justification ==

Impact: The 4.15 hwe kernel includes some package shuffling, so the VersionedKernelPackages list in /etc/apt/apt.conf.d/01autoremove needs to be updated to include linux-modules* packages.

Fix: Backport the conf file changes from bionic.

Test Case: Confirm that linux-modules* packages are autoremoved according to the same rules used for linux-image* packages.

Regression Potential: Minimal. Probably the worst case is that some packages that should be autoremoved are not, but since these changes have been in use in bionic for a while now no regressions are expected.

[Julian Andres Klode (juliank)]

Yup. We probably want an easier test case, though?

[Seth Forshee (sforshee)]

Other than simply checking the patterns in the file, I can't think of an easier way to test. If you know of one please let me know. I do currently have a vm set up to let me test it.

[Seth Forshee (sforshee)]

Hmm, now that I actually look at how the file is used, I guess we could verify the list generated by /etc/kernel/postinst.d/apt-auto-removal, couldn't we?

[Julian Andres Klode (juliank)]

Yeah, probably. I have another two fixes queued, so I'll do a 1.2.27 tomorrow with all of them:

https://salsa.debian.org/apt-team/apt/compare/1.2.26...1.2.y

apt (1.2.27) UNRELEASED; urgency=medium

  [ David Kalnischkies ]
  * don't hang if multiple sources use unavailable method (Closes: 870675)
    (LP: #1762766)

  [ Julian Andres Klode ]
  * Fix lock counting in debSystem (LP: #1778547)
  * apt.conf.autoremove: Catch some new Ubuntu module packages (LP: #1778551)

[Chris J Arges (arges)]

Hello Seth, or anyone else affected,

Accepted apt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.2.27 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Chris J Arges (arges)]

Hello Seth, or anyone else affected,

Accepted apt into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.5.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Julian Andres Klode (juliank)]

Packages for test to inject (4 kernels, -20, 21, 22, 23).

[Julian Andres Klode (juliank)]

Verification done. It shows that with apt 1.2.26, the -22 module-extra are removed, despite their kernel being kept, and that's fixed in 1.2.27. Full log attached, highlight:

Before:
The following packages will be REMOVED:
  libfreetype6 linux-image-4.15.0-20-generic linux-image-4.15.0-21-generic
  linux-modules-4.15.0-20-generic linux-modules-4.15.0-21-generic
  linux-modules-extra-4.15.0-20-generic linux-modules-extra-4.15.0-21-generic
  linux-modules-extra-4.15.0-22-generic

After:

The following packages will be REMOVED:
  libfreetype6 linux-image-4.15.0-20-generic linux-image-4.15.0-21-generic
  linux-modules-4.15.0-20-generic linux-modules-4.15.0-21-generic
  linux-modules-extra-4.15.0-20-generic linux-modules-extra-4.15.0-21-generic

[Julian Andres Klode (juliank)]

Same results on artful

[Launchpad Janitor (janitor)]

This bug was fixed in the package apt - 1.5.2

---------------
apt (1.5.2) artful; urgency=medium

  * apt.conf.autoremove: Catch some new Ubuntu module packages (LP: #1778551)
  * Fix lock counting in debSystem (LP: #1778547)

 -- Julian Andres Klode <email address hidden> Tue, 26 Jun 2018 12:51:24 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for apt has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package apt - 1.2.27

---------------
apt (1.2.27) xenial; urgency=medium

  [ David Kalnischkies ]
  * don't hang if multiple sources use unavailable method (Closes: 870675)
    (LP: #1762766)

  [ Julian Andres Klode ]
  * Fix lock counting in debSystem (LP: #1778547)
  * apt.conf.autoremove: Catch some new Ubuntu module packages (LP: #1778551)

 -- Julian Andres Klode <email address hidden> Tue, 26 Jun 2018 12:55:03 +0200