Escape plus character in apt HTTPS requests to work around Amazon S3 bug

[Quanah Gibson-Mount]

As noted in bug#1003633, S3 is broken when a + sign exists unless it is escaped. This was fixed in 2013 for http based repos. However, it is still broken for https based repositories.

apt-get install zimbra-openssl
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following extra packages will be installed:
  zimbra-openssl-lib
The following NEW packages will be installed:
  zimbra-openssl zimbra-openssl-lib
0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
Need to get 1,324 kB of archives.
After this operation, 6,313 kB of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 https://repo.zimbra.com/apt/87/ trusty/zimbra zimbra-openssl-lib amd64 1.0.1p-1zimbra8.7b1+14.04 [828 kB]
Err https://repo.zimbra.com/apt/87/ trusty/zimbra zimbra-openssl-lib amd64 1.0.1p-1zimbra8.7b1+14.04
  HttpError403
Get:2 https://repo.zimbra.com/apt/87/ trusty/zimbra zimbra-openssl amd64 1.0.1p-1zimbra8.7b1+14.04 [497 kB]
Err https://repo.zimbra.com/apt/87/ trusty/zimbra zimbra-openssl amd64 1.0.1p-1zimbra8.7b1+14.04
  HttpError403
E: Failed to fetch https://repo.zimbra.com/apt/87/pool/zimbra/z/zimbra-openssl/zimbra-openssl-lib_1.0.1p-1zimbra8.7b1+14.04_amd64.deb HttpError403

E: Failed to fetch https://repo.zimbra.com/apt/87/pool/zimbra/z/zimbra-openssl/zimbra-openssl_1.0.1p-1zimbra8.7b1+14.04_amd64.deb HttpError403

E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Escaping the + sign fixes the issue when testing with wget:

root@zre-ldap001:/home/quanah# wget https://repo.zimbra.com/apt/87/pool/zimbra/z/zimbra-openssl/zimbra-openssl_1.0.1p-1zimbra8.7b1%2B14.04_amd64.deb
--2015-11-03 13:11:03-- https://repo.zimbra.com/apt/87/pool/zimbra/z/zimbra-openssl/zimbra-openssl_1.0.1p-1zimbra8.7b1%2B14.04_amd64.deb
Resolving repo.zimbra.com (repo.zimbra.com)... 54.230.4.69, 54.230.6.152, 54.192.4.217, ...
Connecting to repo.zimbra.com (repo.zimbra.com)|54.230.4.69|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 496784 (485K) [application/x-debian-package]
Saving to: ‘zimbra-openssl_1.0.1p-1zimbra8.7b1+14.04_amd64.deb’

100%[===================================================================================================================================================>] 496,784 1.62MB/s in 0.3s

2015-11-03 13:11:04 (1.62 MB/s) - ‘zimbra-openssl_1.0.1p-1zimbra8.7b1+14.04_amd64.deb’ saved [496784/496784]

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Julian Andres Klode (juliank)]

This was fixed as part of bug 1651923 in 1.4 (zesty and newer), and now we even use the http method for https. The fix is also available in xenial, starting with 1.2.19.