random output when size_to_str() passed values larger than 10^28

[James Hunt]

# correct output ("10000 Y" or 10k yottabytes)
$ python2.7 -c 'import apt_pkg; print(apt_pkg.size_to_str(10 ** 28))' |od -xc
0000000 3031 3030 2030 0a59
          1 0 0 0 0 Y \n
0000010

# incorrect output: random output!
$ python2.7 -c 'import apt_pkg; print(apt_pkg.size_to_str(10 ** 29))' |od -xc
0000000 75b0 01ff 8020 b74c 000a
        260 u 377 001 200 L 267 \n
0000011

Admittedly, it'll probably be a while before this becomes an issue ;-)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Barry Warsaw (barry)]

This affects me because my hard drive goes to 11.

[Colin Watson (cjwatson)]

Reproducible with a C++ program linked against libapt-pkg.

#include <apt-pkg/strutl.h>
#include <stdio.h>

void show(double size)
{
    std::string out = SizeToStr(size);
    printf("SizeToStr(%f) = '%s'\n", size, out.c_str());
}

int main()
{
    show(100000000000000000000000000000.0L);
    return 0;
}