[Pull request] Move apt-btrfs-snapshot to daily systemd timers, drop python2 and other changes

Bug #1778256 reported by Mikhail Novosyolov on 2018-06-22
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apt-btrfs-snapshot (Ubuntu)
Undecided
Unassigned

Bug Description

Hello,
I have created a fork of apt-btrfs-snapshot for my own usage and want to propose these changes for upstream.

The code is here: https://gitlab.com/mikhailnov/apt-btrfs-snapshot Please have a look at it. Unfortunately, I have not understood how to send a pull request at Launchpad.

Changes compared to the upstream version 3.5.1:

* Systemd daily timer instead of weekly cron to clean old snapshots
* Do not run the timer when on battery (with no AC power)
* Force btrfs sync after snapshot deletions
* Introduce etc/apt-btrfs-snapshot.conf.d/ directory for config files which are loaded in alpha-numerical order
* /etc/apt-btrfs-snapshot.conf.d/10-default.conf is the default config, but other packages may put other configs into the config directory (for example, I want to override MaxAge on a group of machines and package my own config file /etc/apt-btrfs-snapshot.conf.d/20-my.conf); I will probably add such config to [system-autoupdate](https://gitlab.com/mikhailnov/system-autoupdate)
* Default MaxAge to 15 days (2 weeks + 1 day) instead of 90 days to reduce problems with no empty space left on disk
* Drop support for building with python2

Mikhail Novosyolov (mikhailnov) wrote :

The attachment "Patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
description: updated
Mikhail Novosyolov (mikhailnov) wrote :

Moved the repository to a new URL: https://gitlab.com/nixtux-packaging/apt-btrfs-snapshot
Fixed building on Ubuntu 16.04 xenial by adding dh-systemd build dependency.

Also, made it depend from btrfsmaintenance of my own packaging which is based on Debian's package, the changes are documented here: https://gitlab.com/nixtux-packaging/btrfsmaintenance/tree/master/debian

My PPA repository is: https://launchpad.net/~mikhailnov/+archive/ubuntu/utils/

Mikhail Novosyolov (mikhailnov) wrote :

https://gitlab.com/nixtux-packaging/apt-btrfs-snapshot/commit/29e2864ac59e9a73f4f7359da404bb83127d5139 fixed it on Ubuntu 16.04. python3-dist-utils on 18.04 and python3-dist-utils-extra are required. Without them it may just not work or report that the system is lacking snapshot features. This fixed 'system is lacking snapshot features' error on my Ubuntu 16.04 servers and desktops

Mikhail Novosyolov (mikhailnov) wrote :

I did not update the patch, you may manually pull fixes from my repository

Simon Quigley (tsimonq2) wrote :

I'm unsubscribing the Ubuntu Sponsors Team because it should really be merged upstream.

However, I am subscribing Julian Andres Klode to get some more eyes on this, perhaps it can be taken under the Debian Apt Team umbrella or something of that sort.

Thanks for your work on this.

Mikhail Novosyolov (mikhailnov) wrote :

The upstream of apt-btrfs-snapshot in in Ubuntu, as far as I understand.

Mikhail Novosyolov (mikhailnov) wrote :

Ping. Please at least change dependency from python3-distutils to python3-distutils-extra to fix https://bugs.launchpad.net/ubuntu/+source/apt-btrfs-snapshot/+bug/1763923

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Patches