apt-btrfs-snapshot weekly cron always returns 1

[Arthur Ward]

After installing apt-btrfs-snapshot 0.2.1build1 on 12.04, I get the following email from anacron every week:

run-parts: /etc/cron.weekly/apt-btrfs-snapshot exited with return code 1

After digging through the apt-btrfs-snapshot code, it looks to me like there is a bug in /usr/share/pyshared/apt_btrfs_snapshot.py. "clean_btrfs_root_snapshots_older_than" does not return a value, which /usr/bin/apt-btrfs-snapshot.py treats as an error condition. I think the function should be checking the result of delete_snapshot at each iteration. The fix I made to my system is attached.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "The fix I applied to my system." of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Dark Dragon (darkdragon-001)]

There is another proposed fix: https://github.com/darkdragon-001/apt-btrfs-snapshot/commit/b10d8ab9c50dc7340f0681f6a20d9d14f801f71d#diff-0be248925507a74fb52aae1011e00de4R188-R198