I confirmed the fix is doing as intended on xenial. fwupd doesn't peg the CPU or crash from the bad data. It just exits.
$ sudo /usr/lib/x86_64-linux-gnu/fwupd/fwupd -v
16:23:19 Verbose debugging enabled (on console 1)
16:23:19 adding plugin /usr/lib/x86_64-linux-gnu/fwupd-plugins-1/libfu_plugin_test.so
16:23:19 performing init() on test
16:23:19 adding plugin /usr/lib/x86_64-linux-gnu/fwupd-plugins-1/libfu_plugin_steelseries.so
FuMain: failed to load AppStream data: scanner error: mapping values are not allowed in this context at ln:2 col:5
16:23:19 FuMain: failed to load AppStream data: scanner error: mapping values are not allowed in this context at ln:2 col:5
I confirmed the fix is doing as intended on xenial. fwupd doesn't peg the CPU or crash from the bad data. It just exits.
$ sudo /usr/lib/ x86_64- linux-gnu/ fwupd/fwupd -v x86_64- linux-gnu/ fwupd-plugins- 1/libfu_ plugin_ test.so x86_64- linux-gnu/ fwupd-plugins- 1/libfu_ plugin_ steelseries. so
16:23:19 Verbose debugging enabled (on console 1)
16:23:19 adding plugin /usr/lib/
16:23:19 performing init() on test
16:23:19 adding plugin /usr/lib/
FuMain: failed to load AppStream data: scanner error: mapping values are not allowed in this context at ln:2 col:5
16:23:19 FuMain: failed to load AppStream data: scanner error: mapping values are not allowed in this context at ln:2 col:5