ubiquity source package hook should move more bugs to grub-installer

Bug #878335 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Medium
Brian Murray

Bug Description

The source package hook does some investigation to see if the problem is in grub-installer and moves the bug to that package. However, that code only runs if the problem type is not 'bug' which is a lot of cases.

    if report['ProblemType'] != 'Bug' and not 'Traceback' in report:
        collect_grub = False
        collect_trace = False
        if not 'grub-installer: Installation finished. No error reported' in syslog and 'grub-installer:' in syslog:
            collect_grub = True
        if 'Traceback' in syslog:
            collect_trace = True
        if collect_grub or collect_trace:
            duplicate_signature = prepare_duplicate_signature(syslog,
                collect_grub, collect_trace)
            if duplicate_signature:
                report['DuplicateSignature'] = duplicate_signature
        if collect_grub:
            report['SourcePackage'] = 'grub-installer'

I believe this was change due to incorrect duplicate signature creation so perhaps the problem type check should be moved to the duplicate signature part.

Changed in apport (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 1.92-0ubuntu1

---------------
apport (1.92-0ubuntu1) precise; urgency=low

  [ Martin Pitt ]
  * New upstream release:
    - man/apport-bug.1: Mention where crash files are stored. Thanks David
      Kastrup.
    - hookutils.py, attach_hardware(): Sort ProcModules, thanks Brian Murray.
    - launchpad.py: Keep "Dependencies" attachment in duplicates. Thanks Brian
      Murray.
    - Reorganize the GNOME and KDE user interface to do the crash
      notifications and detail browser in a single dialog. Add test/gtk and
      test/kde tests to check expected dialog layout for different cases.
      Thanks Evan Dandrea!
    - Add support for the whoopsie-daisy crash reporting daemon by creating
      zero-byte .upload file stamps for crash reports. Thanks Evan Dandrea!
    - ui.py: Fix wrong creation of "~" folder instead of expanding it to home
      directory when using "Examine locally". Thanks Jason Conti!
      (LP: #909149)
    - Replace file() calls with open() for Python 3 compatibility. Thanks
      Colin Watson!
    - launchpad.py: Avoid sending tag names with upper case. (LP: #924181)
    - report.py, crash_signature_addresses(): Fix crash if report does not
      have "Signal".
    - apport-gtk: Fix resize handling of expander in details window. Thanks
      Thomas Bechtold! (LP: #930562)
    - Clean up unnecessary imports. Thanks Evan Dandrea!
  * debian/apport-kde.install: Ship new spinner.gif.

  [ Brian Murray ]
  * data/package-hooks/source_ubiquity.py: include kernel command line from
    ubiquity syslog in the report as InstallCmdLine
  * data/package-hooks/source_ubiquity.py: move apport-bug failures due to
    grub-installer to that package (LP: #878335)
  * debian/control: Add xvfb dependency so that the test suite can run the GUI
    tests.
 -- Martin Pitt <email address hidden> Mon, 20 Feb 2012 16:55:29 +0100

Changed in apport (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.