Add hook to attach Upstart override files

Bug #803977 reported by James Hunt on 2011-06-30
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Wishlist
Brian Murray

Bug Description

As a follow-on to bug 803963, it would be great if apport could also attach any Upstart "override files" that have been created for a packages Upstart jobs.

Details
=====

Since the introduction of Upstart override files:

    http://upstart.ubuntu.com/cookbook/#ubuntu-natty-override-files

... it is now possible to create a "/etc/init/<job>.override" file that
can potentially completely change the behaviour of a service that is
controlled by Upstart.

As such, it would be great if apport were to look automatically attach
the associated ".override" file(s) to bug reports for a package.

Strategy should be to determine if any of the packages conffiles are
Upstart Job Configuration Files (files that match the pattern
"^/etc/init/.*\.conf") and if any of these have a corresponding
".override" file, attach the override file to the bug.

Assuming a package has a config file specified as "/etc/init/foo.conf",
in shell syntax...

  conf_file=/etc/init/foo.conf
  override_file=${conf_file/.conf/.override}

  if [ -e "$override_file" ]
  then
    # need to save packages override file corresponding to foo.conf
  fi

Related branches

Changed in apport (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Changed in apport (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Brian Murray (brian-murray)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 1.21.2-0ubuntu7

---------------
apport (1.21.2-0ubuntu7) oneiric; urgency=low

  [ Martin Pitt ]
  * data/general-hooks/ubuntu.py: Fix calling of add_info() in the __main__
    test code.

  [ Brian Murray ]
  * data/package-hooks/source_ubiquity.py:
    - collect all logs using root_command_outputs (LP: #812738)
  * apport/hookutils.py:
    - check to see if the package has any upstart override files
  * data/general-hooks/ubuntu.py:
    - when reporting a problem use the upstart override check (LP: #803977)
 -- Martin Pitt <email address hidden> Fri, 22 Jul 2011 16:51:22 +0200

Changed in apport (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers