Changes to support suspend/hibernate/resume testing

Bug #316419 reported by Steve Conklin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Medium
Andy Whitcroft
linux (Ubuntu)
Fix Released
Medium
Andy Whitcroft
pm-utils (Ubuntu)
Fix Released
Medium
Andy Whitcroft

Bug Description

In order to maximise testing and reporting on failed suspend/hibernate/resume cycles we are proposing to modify processing such it is possible to track whether a suspend/hibernate was in progress. This allows us to detect this on normal boot and then report it via apport to launchpad. Additionally we are delivering a suspend stress test. Change fall into three parts:

 - kernel: shipping the suspend stress test script with the kernel image itself,
 - pm-utils: modifications to actually track the what operations are in progress, and
 - apport: adding a new type of report for failed operations.

---
KERNEL:
The changes here are already applied and released.

PM-UTILS:
simple new sleep.d script to expose the current 'in-progress' operations such that external scripts can detect it indicating a failure during that operation.

APPORT:
There are changes required to apport in order to support reporting of suspend/resume problems. During suspend and hibernate, pm-utils will create a 'flag' file while going down, and remove it while coming up. When the apport init script start function runs, it will check for the existence of this flag file. If it is present, it is assumed that a previous resume failed and that the user restarted the machine.

These changes to apport add the check in the init script. If the flag file exists, then a python script is called which creates a crash report file in /var/crash for later processing by apport, and the flag file is deleted.

Martin Pitt has reviewed these [changes to apport] and approved them, but he's on holiday this week, so could someone else please push them into Jaunty?

Revision history for this message
Steve Conklin (sconklin) wrote :
Revision history for this message
Steve Conklin (sconklin) wrote :
Andy Whitcroft (apw)
description: updated
Changed in linux:
assignee: nobody → apw
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Andy Whitcroft (apw) wrote :

Attached to this comment are the proposed changes to pm-utils to record the current operation. Currently this is done via a new sleep.d script.

Changed in pm-utils:
assignee: nobody → apw
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Andy Whitcroft (apw) wrote :

I have taken Steve Conklin's two patches and applied them to a bzr branch of apport which is published below:

    https://code.launchpad.net/~apw/apport/suspend-resume

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 2.6.28-4.10

---------------
linux (2.6.28-4.10) jaunty; urgency=low

  [ Andy Whitcroft ]

  * update kernel bootloader recommends: to prefer grub
    - LP: #314004
  * SAUCE: don't use buggy _BCL/_BCM/_BQC for backlight control
    - LP: #311716
  * SAUCE: test-suspend -- add the suspend test scripts
    - LP: #316419

  [ Colin Watson ]

  * Enable udebs for armel

  [ Tim Gardner ]

  * SAUCE: Dell laptop digital mic does not work, PCI 1028:0271
    - LP: #309508
  * Enable CIFS_XATTR=y and CONFIG_CIFS_POSIX=y
    - LP: #220658

 -- Tim Gardner <email address hidden> Thu, 08 Jan 2009 10:38:22 -0700

Changed in linux:
status: Fix Committed → Fix Released
Revision history for this message
Andy Whitcroft (apw) wrote :

Sponsors: am looking to get two fixes applied to complete the trio here and enable the functionality described in the summary:

1. the debdiff fixes for pm-utils in comment #3, and
2. the differences to apport on the branch in comment #4.

Changed in apport:
assignee: nobody → apw
importance: Undecided → Medium
status: New → In Progress
Andy Whitcroft (apw)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 0.127

---------------
apport (0.127) jaunty; urgency=low

  * bin/apportcheckresume, debian/apport.init: integrate with pm-utils to
    detect suspend/resume failures. Thanks to Steve Conklin and Andy
    Whitcroft. LP: #316419.

 -- Steve Langasek <email address hidden> Tue, 13 Jan 2009 12:54:12 -0800

Changed in apport:
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pm-utils - 1.2.2.1-0ubuntu2

---------------
pm-utils (1.2.2.1-0ubuntu2) jaunty; urgency=low

  * Add suspend/hibernate in progress tracking to allow better error
    reporting on failed suspend/hibernate cycles. apport will detect
    the new status file and submit bugs when found. (LP: #316419)

 -- Andy Whitcroft <email address hidden> Mon, 12 Jan 2009 16:29:41 +0000

Changed in pm-utils:
status: In Progress → Fix Released
Revision history for this message
Matt Zimmerman (mdz) wrote :

The pm-utils change seems to be ineffective, see bug 318267

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.