Some tests are flaky due to timeout

Bug #1780767 reported by Didier Roche on 2018-07-09
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
High
Brian Murray
Bionic
Medium
Brian Murray

Bug Description

The autopkgtests are sometimes passing, sometimes stuck for more than 2h:
http://autopkgtest.ubuntu.com/packages/apport/cosmic/amd64.
It's blocking randomly on different tests.

All tests that are stucked, implements closing a request via a timeout (and then, executing "run"). The bet is that the timeout is short enough (1s) so that, when autopkgtests infra is busy, time to execute the bash subcommand is taking more than a second, and so "dismissing" is ran before execution happens and the whole testsuite hangs.

There are few instances of setting this timeout function:
$ grep eout_add_sec test/*
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, cont)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, cont)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, cont)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, c)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, c)

Short term solution could be to increase the timeout. Long term would be to eliminate this potential race implementing cancelling differently.

tags: added: rls-cc-incoming
Changed in apport (Ubuntu):
status: New → In Progress
assignee: nobody → Brian Murray (brian-murray)
importance: Undecided → High
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.10-0ubuntu7

---------------
apport (2.20.10-0ubuntu7) cosmic; urgency=medium

  * tests/test_ui_gtk.py: Increase the timeout so that when the autopkgtest
    infrastructure is busy the tests should not fail. (LP: #1780767)

 -- Brian Murray <email address hidden> Tue, 24 Jul 2018 08:03:49 -0700

Changed in apport (Ubuntu):
status: In Progress → Fix Released
Łukasz Zemczak (sil2100) wrote :

Could this be backported to bionic with the next SRU? We're possibly seeing the same timeout issues there.

Changed in apport (Ubuntu Bionic):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Brian Murray (brian-murray)

Hello Didier, or anyone else affected,

Accepted apport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.9-0ubuntu7.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in apport (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Brian Murray (brian-murray) wrote :

The i386 and amd64 autopkgtests passed for Ubuntu 18.04 with the new version of apport in -proposed.

http://autopkgtest.ubuntu.com/packages/a/apport/bionic/amd64
http://autopkgtest.ubuntu.com/packages/a/apport/bionic/i386

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic

The verification of the Stable Release Update for apport has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.9-0ubuntu7.5

---------------
apport (2.20.9-0ubuntu7.5) bionic; urgency=medium

  * apport/ui.py: when using ubuntu-bug properly handle executables which
    start with /snap/bin. (LP: #1760220)
  * test/test_ui_gtk.py: Increase the timeout so that when the autopkgtest
    infrastructure is busy the tests should not fail. (LP: #1780767)

 -- Brian Murray <email address hidden> Fri, 02 Nov 2018 08:19:37 -0700

Changed in apport (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers