Some tests are flaky due to timeout

Bug #1780767 reported by Didier Roche on 2018-07-09
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
High
Brian Murray

Bug Description

The autopkgtests are sometimes passing, sometimes stuck for more than 2h:
http://autopkgtest.ubuntu.com/packages/apport/cosmic/amd64.
It's blocking randomly on different tests.

All tests that are stucked, implements closing a request via a timeout (and then, executing "run"). The bet is that the timeout is short enough (1s) so that, when autopkgtests infra is busy, time to execute the bash subcommand is taking more than a second, and so "dismissing" is ran before execution happens and the whole testsuite hangs.

There are few instances of setting this timeout function:
$ grep eout_add_sec test/*
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, cont)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, cont)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, cont)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, c)
test/test_ui_gtk.py: GLib.timeout_add_seconds(1, c)

Short term solution could be to increase the timeout. Long term would be to eliminate this potential race implementing cancelling differently.

tags: added: rls-cc-incoming
Changed in apport (Ubuntu):
status: New → In Progress
assignee: nobody → Brian Murray (brian-murray)
importance: Undecided → High
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.10-0ubuntu7

---------------
apport (2.20.10-0ubuntu7) cosmic; urgency=medium

  * tests/test_ui_gtk.py: Increase the timeout so that when the autopkgtest
    infrastructure is busy the tests should not fail. (LP: #1780767)

 -- Brian Murray <email address hidden> Tue, 24 Jul 2018 08:03:49 -0700

Changed in apport (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers