PythonDetails contains an error message if python not installed

Bug #1769262 reported by Brian Murray on 2018-05-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Undecided
Unassigned
Bionic
Low
Brian Murray

Bug Description

[Test Case]
0) ensure python is not installed on the system
1) launch update-manager
2) kill update-manager
3) view the crash report

With the version of apport in the archive you will see messy PythonDetails like below. With the version of apport from -proposed you will instead see:

PythonDetails: N/A

[Regression Potential]
The fix for this also modified the code which creates Python3Details so we should ensure that Python3Details is not broken.

Original Description
--------------------
In an Ubuntu 18.04 apport-package report, bug 1768866, we can see the following which looks super messy:

PythonDetails: /root/Error: command ['which', 'python'] failed with exit code 1:, Error: [Errno 2] Aucun fichier ou dossier de ce type: "/root/Error: command ['which', 'python'] failed with exit code 1:": "/root/Error: command ['which', 'python'] failed with exit code 1:", unpackaged

Brian Murray (brian-murray) wrote :

This'll make it look nicer.

@@ -519,6 +519,9 @@
 def add_python_details(key, python, report):
     '''Add comma separated details about which python is being used'''
     python_path = apport.hookutils.command_output(['which', python])
+ if python_path.startswith('Error: '):
+ report[key] = 'N/A'
+ return
     python_link = apport.hookutils.command_output(['readlink', '-f',
                                                   python_path])
     python_pkg = apport.fileutils.find_file_package(python_path)

description: updated
tags: added: id-5ae35ea55ac10e9203cade8d
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.10-0ubuntu1

---------------
apport (2.20.10-0ubuntu1) cosmic; urgency=medium

  * New upstream release:
    - backends/packaging-apt-dpkg.py: when using a permanent sandbox better
      check for the package being already available thereby reducing quantity
      of downloads.
    - apport/report.py: Use timeout parameter in subprocess to limit how long
      we'll wait for gdb to return information as gdb can hang with some core
      files.
    - data/apport: Fix PEP8 issues
    - apport/ui.py: Include ProblemType in reports which are updated as
      package hooks may expect the report to have a ProblemType. (LP: #1766794)
    - test/test_ui.py: modify run_crash_kernel test to account for the fact
      that linux-image-$kvers-$flavor is now built from the linux-signed
      source package on amd64 and ppc64el. (LP: #1766740)
  * data/general-hooks/ubuntu.py: Fix UnicodeDecodeError when processing
    DpkgTerminalLog. (LP: #1766337)
  * data/general-hooks/ubuntu.py: Don't display a messy error if python or
    python3 is not installed. (LP: #1769262)
  * debian/apport.links: source_linux-signed.py -> source_linux.py package
    hook (LP: #1766740)
  * data/package-hooks/source_linux.py: Redirect bugs filed about the
    linux-signed source package to linux. (LP: #1766740)

 -- Brian Murray <email address hidden> Thu, 10 May 2018 09:31:34 -0700

Changed in apport (Ubuntu):
status: New → Fix Released
Changed in apport (Ubuntu Bionic):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Brian Murray (brian-murray)
description: updated
description: updated

Hello Brian, or anyone else affected,

Accepted apport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.9-0ubuntu7.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in apport (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Brian Murray (brian-murray) wrote :

The test case passed with the version of apport from bionic-proposed.

bdmurray@clean-bionic-amd64:~$ grep Python /var/crash/_usr_bin_update-manager.1000.crash
Python3Details: /usr/bin/python3.6, Python 3.6.5, python3-minimal, 3.6.5-3
PythonDetails: N/A
bdmurray@clean-bionic-amd64:~$ apt-cache policy apport
apport:
  Installed: 2.20.9-0ubuntu7.2
  Candidate: 2.20.9-0ubuntu7.2

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.9-0ubuntu7.2

---------------
apport (2.20.9-0ubuntu7.2) bionic; urgency=medium

  * apport/ui.py: Include ProblemType in reports which are updated as
    package hooks may expect the report to have a ProblemType. (LP: #1766794)
  * test/test_ui.py: modify run_crash_kernel test to account for the fact
    that linux-image-$kvers-$flavor is now built from the linux-signed
    source package on amd64 and ppc64el. (LP: #1766740)
  * data/general-hooks/ubuntu.py: Don't display a messy error if python or
    python3 is not installed. (LP: #1769262)
  * debian/apport.links: source_linux-signed.py -> source_linux.py package
    hook (LP: #1773012)
  * data/package-hooks/source_linux.py: Redirect bugs filed about the
    linux-signed source package to linux. (LP: #1773012)

 -- Brian Murray <email address hidden> Wed, 30 May 2018 15:19:49 -0700

Changed in apport (Ubuntu Bionic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for apport has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers