apport-collect SHOULD NOT collect gnome-shell command history and favorites

Bug #1739531 reported by fermulator on 2017-12-21
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
High
Brian Murray
Bionic
High
Brian Murray

Bug Description

In https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1739525/comments/4, I ran apport-collect for that bug report.

To my horror, it posted "org.gnome.shell command-history" and "favorites" in the "GsettingsChanges.txt"!
https://launchpadlibrarian.net/349970997/GsettingsChanges.txt

It's _completely_ reasonable to see:
 * enabled-extensions
 * org.gnome.shell.* diffs
 * org.gnome.desktop.* diffs

But it is _NOT_ acceptable (privacy reasons) to automatically harvest a user's favorites in the gnome-shell, nor their command histories.

_IF_ we must harvest for bug-data gathering, it MUST come in a secure mechanism that is private only to submitter + the assigned dev.

fermulator (fermulator) on 2017-12-21
description: updated
summary: - apport-collect SHOULD NOT collect gnome-shell command history
+ apport-collect SHOULD NOT collect gnome-shell command history and
+ favorites
Daniel van Vugt (vanvugt) wrote :

I agree. I've never seen that happen before either, till now.

Changed in apport (Ubuntu):
importance: Undecided → High
status: New → Confirmed
Brian Murray (brian-murray) wrote :

The gnome-shell apport package hook contains the following code:

 14 attach_gsettings_package(report, 'gnome-shell-common')
 15 attach_gsettings_schema(report, 'org.gnome.desktop.interface')

So not every apport bug report will include gnome-shell command history and favorites.

tags: added: rls-bb-incoming
tags: removed: rls-bb-incoming
tags: added: id-5a4e56c663f9687b2b0de38d
Changed in apport (Ubuntu Bionic):
assignee: nobody → Brian Murray (brian-murray)
Changed in apport (Ubuntu Bionic):
status: Confirmed → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.9-0ubuntu4

---------------
apport (2.20.9-0ubuntu4) bionic; urgency=medium

  * apport/hookutils.py: When gathering gsettings schema changes redact
    information regarding command-history and favorite-apps from gnome-shell.
    (LP: #1739531)

 -- Brian Murray <email address hidden> Thu, 05 Apr 2018 10:51:59 -0700

Changed in apport (Ubuntu Bionic):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers