apport crashed with FileNotFoundError in is_container_pid(): [Errno 2] No such file or directory: '/proc/11102/ns/pid'

[rajesh]

https://errors.ubuntu.com/problem/b6b178fe6ed572189dbfe2627876ed9e9d59ace2

---

It appears that after login this was the first action performed by the system which resulted in the generation of the crash report.

ProblemType: Crash
DistroRelease: Ubuntu 18.04
Package: apport 2.20.8-0ubuntu1
ProcVersionSignature: Ubuntu 4.13.0-16.19-generic 4.13.4
Uname: Linux 4.13.0-16-generic x86_64
ApportVersion: 2.20.8-0ubuntu1
Architecture: amd64
CrashReports: 640:0:119:17503:2017-11-20 01:59:45.143901348 +0530:2017-11-20 01:59:46.143901348 +0530:/var/crash/_usr_share_apport_apport.0.crash
Date: Mon Nov 20 01:59:46 2017
ExecutablePath: /usr/share/apport/apport
InstallationDate: Installed on 2017-11-19 (1 days ago)
InstallationMedia: Ubuntu 18.04.0 2017.11.11 amd64 "Unity 7 Desktop Experience Bionic Beaver"
InterpreterPath: /usr/bin/python3.6
PackageArchitecture: all
ProcCmdline: /usr/bin/python3 /usr/share/apport/apport 11102 11 0 1 11102
ProcEnviron:

Python3Details: /usr/bin/python3.6, Python 3.6.3, python3-minimal, 3.6.3-0ubuntu2
PythonArgs: ['/usr/share/apport/apport', '11102', '11', '0', '1', '11102']
PythonDetails: /root/Error: command ['which', 'python'] failed with exit code 1:, Error: [Errno 2] No such file or directory: "/root/Error: command ['which', 'python'] failed with exit code 1:": "/root/Error: command ['which', 'python'] failed with exit code 1:", unpackaged
SourcePackage: apport
Title: apport crashed with FileNotFoundError in is_container_pid(): [Errno 2] No such file or directory: '/proc/11102/ns/pid'
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups:

[Mike Hardy (mikehardy)]

I see the same thing on Ubuntu 16.04 / apport 2.20.1-0ubuntu2.14 - same apport command line (except a different PID number), same error number and everything.

Looks like 'is_same_ns' is blindly doing an os.readlink on a path that it assumes must exist (because it does no defensive check) but the path clearly is missing sometimes

[Brian Murray (brian-murray)]

There is an errors bucket for this:

https://errors.ubuntu.com/problem/b6b178fe6ed572189dbfe2627876ed9e9d59ace2

[Brian Murray (brian-murray)]

The updates for this fix will need to go through security since many people are getting the package from there.

[Brian Murray (brian-murray)]

artful fix

[Brian Murray (brian-murray)]

zesty fix

[Brian Murray (brian-murray)]

xenial fix

[Seth Arnold (seth-arnold)]

Note that these fixes are susceptible to a race condition; better would handle the exception from Python. Probably returning 'false' is the right option in that case. (Assuming that's the case that then does less processing.)

Thanks

[Seth Arnold (seth-arnold)]

To clarify, I think these patches may reduce the number of reports in the error tracker; but to eliminate the reports, the exception needs to be handled.

Thanks

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.8-0ubuntu4

---------------
apport (2.20.8-0ubuntu4) bionic; urgency=medium

  * data/apport: add a second os.path.exists check to ensure we do not
    receive a Traceback in is_container_id(). (LP: #1733366)

 -- Brian Murray <email address hidden> Wed, 13 Dec 2017 10:30:23 -0800

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Brian Murray (brian-murray)]

Here's an improved artful debdiff taking into account Seth's comments.

[Brian Murray (brian-murray)]

Here's a zesty debdiff.

[Brian Murray (brian-murray)]

And the xenial one.

[Tyler Hicks (tyhicks)]

Thanks for the updated debdiffs! They look pretty good to me but I'm wondering if was intentional that True is returned when the "not os.path.exists()" checks are true but the exception handler returns False when os.readlink() throws an errno.ENOENT OSError exception? IIUC, both situations occur when the namespace files don't exist but one situation returns True and the other False.

Should both situations return True? If so, I can make those changes before sponsoring so there's no need to upload new debdiffs.

[Brian Murray (brian-murray)]

Ah, yes it should return True. Thanks for catching that! To be absolutely clear:

311 except OSError as e:
312 if e.errno == errno.ENOENT:
313 return True

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.4-0ubuntu4.10

---------------
apport (2.20.4-0ubuntu4.10) zesty-security; urgency=medium

  * REGRESSION UPDATE: Fix regression that caused a Traceback in the
    container support (LP: #1733366)
    - data/apport: add a second os.path.exists check to ensure we do not
      receive a Traceback in is_container_id() and add an exception handler in
      case either name space can not be found.

 -- Brian Murray <email address hidden> Wed, 13 Dec 2017 10:51:39 -0800

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.1-0ubuntu2.15

---------------
apport (2.20.1-0ubuntu2.15) xenial-security; urgency=medium

  * REGRESSION UPDATE: Fix regression that caused a Traceback in the
    container support (LP: #1733366)
    - data/apport: add a second os.path.exists check to ensure we do not
      receive a Traceback in is_container_id() and add an exception handler in
      case either name space can not be found.

 -- Brian Murray <email address hidden> Wed, 13 Dec 2017 10:54:26 -0800

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.7-0ubuntu3.7

---------------
apport (2.20.7-0ubuntu3.7) artful-security; urgency=medium

  * REGRESSION UPDATE: Fix regression that caused a Traceback in the
    container support (LP: #1733366)
    - data/apport: add a second os.path.exists check to ensure we do not
      receive a Traceback in is_container_id() and add an exception handler in
      case either name space can not be found.

 -- Brian Murray <email address hidden> Wed, 13 Dec 2017 10:49:58 -0800

[Brian Murray (brian-murray)]

This could use fixing for Trusty too.

https://errors.ubuntu.com/problem/385d2e8ecf335dc2cdd7216506bbf2b6e6b8751c

[Brian Murray (brian-murray)]

The function was slightly in Trusty but the attached debdiff should fix the crash seen in the Error Tracker.

[Steve Beattie (sbeattie)]

Thanks, Brian, reviewing now.

[Steve Beattie (sbeattie)]

I've uploaded the trusty apport package to the ubuntu-security-proposed ppa (https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/) for testing, and will likely release this next week. Any feedback is appreciated.

Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.14.1-0ubuntu3.28

---------------
apport (2.14.1-0ubuntu3.28) trusty-security; urgency=medium

  * REGRESSION UPDATE: Fix regression that caused a Traceback in the
    container support (LP: #1733366)
    - data/apport: add a second os.path.exists check to ensure we do not
      receive a Traceback in is_container_id() and add an exception handler in
      case either name space can not be found.

 -- Brian Murray <email address hidden> Fri, 20 Apr 2018 14:11:44 -0700