Do not add retraces if the bug is a duplicate

Bug #172792 reported by Emilio Pozuelo Monfort
2
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Wishlist
Martin Pitt

Bug Description

Binary package hint: apport

I just got a mail like this (simplified):

*** This bug is a duplicate of bug 155424 ***
    https://bugs.launchpad.net/bugs/155424

** Attachment added: "ThreadStacktrace.txt (retraced)"

** Attachment removed: "Disassembly.txt"
** Attachment removed: "Stacktrace.txt"
** Attachment removed: "ThreadStacktrace.txt (retraced)"
** Attachment removed: "ThreadStacktrace.txt"
** Attachment removed: "Stacktrace.txt (retraced)"

If apport is going to remove all the crash attachments it doesn't make sense to attach the retraced ones to remove them later.
It should first check whether the bug is a duplicate or not, instead of adding the duplicates and later removing them.

Changed in apport:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in bzr head.

Changed in apport:
assignee: nobody → pitti
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 0.103

---------------
apport (0.103) hardy; urgency=low

  * bin/apport-unpack: Print error messages instead of crashing for problems
    like nonexisting file names passed as arguments. (LP: #185273)
  * backends/packaging-apt-dpkg.py, is_distro_package(): Explicitly check site
    for "ppa", so that we do not automatically file bugs for PPA packages.
    This works around Soyuz bug LP #140412 for the time being.
  * apport/report.py: Add standard_title() test cases for Python crashes with
    a custom message, and a custom message with newlines. The latter
    reproduces LP #190947.
  * apport/report.py, standard_title(): Do not rely on a fixed position of the
    topmost function; use iteration and regular expression matching instead.
    (LP: #190947)
  * apport/ui.py, parse_argv(): Specify that --pid/-P argument must be an
    integer, to avoid exceptions when it's not. (LP: #193494)
  * apport/report.py: Use uname -srm, not -a, to hide the hostname. (part of
    LP #192786); also use os.uname() instead of calling the system program.
  * problem_report.py(): Make write() work for reports with CompressedValues.
    Add test case.
  * apport/ui.py: Add test case test_run_crash_anonymity() which asserts that
    the crash dump does not contain strings which can identify the user, such
    as the user name, login name, host name, and current directory.
  * apport/report.py: Add method anonymize() which replaces user specific
    strings with generic ones.
  * apport/ui.py, thread_collect_info(): Call anonymize() on the report.
    (LP: #192786)
  * bin/apport-retrace: Only update a bug report with new attachments if it is
    not a duplicate. (LP: #172792)
  * bin/apport-retrace: Print out proper error message instead of an exception
    if trying to do write operations to the bug tracker without specifying
    a cookie file. (LP: #146423)

 -- Martin Pitt <email address hidden> Mon, 25 Feb 2008 17:47:13 +0100

Changed in apport:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers