package_hook does not include package version

[Brian Murray]

All of these problem reports are missing a package version:

https://errors.ubuntu.com/problem/abc807de9d9c87d965fea31c865192edb30b6738

This is because package_hook in apport only writes the following:

pr['Package'] = options.package

We should include the package version in the problem report.

Test Case
---------
1) echo "You have failed this city." | /usr/share/apport/package_hook -p apport
2) grep "^Package" /var/crash/apport.1000.crash

With the current version of apport you'll only see the package name, with the version from -proposed you'll see the package version in addition to the name.

Regression Potential
--------------------
Worst case scenario I screwed the patch up and we loose the package name too, but given that it works in wily and there is a test for it in test_hooks.py that seems unlikely.

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.18-0ubuntu7

---------------
apport (2.18-0ubuntu7) wily; urgency=medium

  * data/package_hook: When creating a Package problem write the version of
    the package to the report. (LP: #1485787)

 -- Brian Murray <email address hidden> Mon, 17 Aug 2015 15:40:39 -0700

[Brian Murray (brian-murray)]

Hello Brian, or anyone else affected,

Accepted apport into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.17.2-0ubuntu1.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello Brian, or anyone else affected,

Accepted apport into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.14.1-0ubuntu3.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Martin Pitt (pitti)]

Note that this isn't how apport is supposed to work: Calling any hook is *not* sufficient for producing a report, you have to let the UI post-process the report; that will call add_package_info() and thus the complete package and version. If you run the test case, and click on "show details", you will see package and version without this patch. I'd therefore like to revert this change in wily.

[Martin Pitt (pitti)]

So how come that the error tracker is not getting add_package_info()? This is a deeper problem as we also need to check for/add package origins, modified files, etc.

[Martin Pitt (pitti)]

Will handle the fix for wily in bug 1485773.

[Martin Pitt (pitti)]

See https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1485773/comments/5 . After actually having looked at this I think that hooks should write a complete Package: field after all; otherwise we force apport to always rewrite the entire apport file, which can be really expensive. So I will fix the hooks after all, see that this becomes simpler, and adjust the tests to catch this.

[Martin Pitt (pitti)]

Fixed in trunk: http://bazaar.launchpad.net/~apport-hackers/apport/trunk/revision/2996

[Brian Murray (brian-murray)]

r2996 does not change the iwlwifi_error_dump hook or the apportcheckresume hook which also writes a Package field to its report.

[Martin Pitt (pitti)]

Thanks Brian! Fixed in http://bazaar.launchpad.net/~apport-hackers/apport/trunk/revision/2998 . I went through all data/*, should be complete now.

[Brian Murray (brian-murray)]

Setting up apport (2.17.2-0ubuntu1.4) ...
bdmurray@blacklightning:~$ echo "You have failed this city." | /usr/share/apport/package_hook -p apport
bdmurray@blacklightning:~$ grep "^Package" /var/crash/apport.1000.crash
Package: apport 2.17.2-0ubuntu1.4

[Brian Murray (brian-murray)]

Setting up apport (2.14.1-0ubuntu3.13) ...
apport start/running
bdmurray@clean-trusty-amd64:~$ echo "You have failed this city." | /usr/share/apport/package_hook -p apport
bdmurray@clean-trusty-amd64:~$ grep "^Package" /var/crash/apport.1000.crash
Package: apport 2.14.1-0ubuntu3.13

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.14.1-0ubuntu3.13

---------------
apport (2.14.1-0ubuntu3.13) trusty-proposed; urgency=medium

  * data/package_hook: when creating the problem report include the version of
    the package. (LP: #1485787)

 -- Brian Murray <email address hidden> Wed, 26 Aug 2015 16:16:52 -0700

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for apport has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.17.2-0ubuntu1.4

---------------
apport (2.17.2-0ubuntu1.4) vivid-proposed; urgency=medium

  * data/package_hook: when creating the problem report include the version of
    the package. (LP: #1485787)

 -- Brian Murray <email address hidden> Wed, 26 Aug 2015 15:49:41 -0700

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.18.1-0ubuntu1

---------------
apport (2.18.1-0ubuntu1) wily; urgency=medium

  * New upstream bug fix release. Changes since our previous snapshot:
    - packaging.py: Only consider first word in /etc/os-release's NAME value.
      This works around Debian's inconsistent value. (LP: #1408245)
    - Unify and simplify Package: field generation in kernel_crashdump,
      kernel_oops, and package_hook by using the new Report.add_package()
      method. (LP: #1485787)
    - sandboxutils.py, make_sandbox(): Make "Cannot find package which ships
      Executable/InterpreterPath" fatal, to save some unnecessary package
      unpack cycles. (LP: #1487174)
  * etc/apport/crashdb.conf: Enable crash reports on Launchpad for wily.
    Really late, sorry about that!

 -- Martin Pitt <email address hidden> Thu, 10 Sep 2015 11:48:46 +0200