hooks: don't add incomplete Package: information
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
apport (Ubuntu) |
In Progress
|
Medium
|
Martin Pitt |
Bug Description
I was trying to figure out why package installation failures didn't always have package versions in them e.g.
https:/
https:/
Digging into this I discovered that package_hook from apport writes a Package key but does not include the version of the package with that key. Apparently, I fixed the same thing 18 months ago with the kernel_oops file.
apport (2.13.2-0ubuntu4) trusty; urgency=medium
* data/kernel_oops: include the package version in addition to the name
-- Brian Murray <email address hidden> Fri, 14 Feb 2014 14:09:39 -0800
Investigating the matter further it, report.write() is called with new_only=True which means that even though the package version information has been collected (by add_package_info) we do not write it to the report. Naturally, this is rather confusing and means that fixes to data collection in apport may not appear in all reports e.g. if we change how origin information is calculated (which appears in the value for Package) we need to change package_hook and kernel_oops for the updated origin information.
Changed in apport (Ubuntu): | |
importance: | Undecided → Medium |
summary: |
- new_only option when writing reports stops some data from being written + only_new option when writing reports stops some data from being written |
Changed in apport (Ubuntu): | |
milestone: | none → ubuntu-15.09 |
Changed in apport (Ubuntu): | |
milestone: | ubuntu-15.09 → none |
I'm going to go ahead and just add the version information in the package_hook, but pitti could you have a look at the larger issue?