whoopsie-upload-all will run hooks on a corrupt crash file multiple times
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
apport (Ubuntu) |
Fix Released
|
Medium
|
Brian Murray |
Bug Description
whoopsie-upload-all in it's process_report() function will try to collect information for a crash with a truncated core dump every time it is called thereby wasting resources on a device.
I'm looking at the following code:
if 'Dependencies' in r:
print('%s already has info collected' % report)
else:
# add minimal hook information here; whoopsie only considers
# ApportVersion, NonfreeKernelMo
try:
except Exception as e:
try:
except (IOError, EOFError) as e:
return None
Because the report is never written Dependencies is never added to the report, so every time whoopsie-upload-all is called it will run add_hooks_info() and add_gdb_info() for the same report.
tags: | added: utopic |
Changed in apport (Ubuntu): | |
assignee: | nobody → Brian Murray (brian-murray) |
status: | Triaged → In Progress |
Right, I think the exception handler for the add_gdb_info() call should unlink() the report then, as it's broken and useless. Do you agree?