'not a debian format' package install failures should be Unreportable
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
apport (Ubuntu) |
Fix Released
|
Medium
|
Brian Murray | ||
Precise |
Fix Released
|
Medium
|
Brian Murray |
Bug Description
In bug 1001715 we can see a package installation failure with the message:
dpkg-deb: error: `/var/cache/
These should not be reportable as they are indicative a corrupt or faulty package. I've committed a fix for this to apport for Quantal:
http://
However, only 24 of these have been reported so far:
so an SRU may not be worth the work. In the event the we decide it is Steve Langasek came up with the following for recreating the error with a good package:
#!/bin/sh
set -e
for i in "$@"
do
case $i in
cp /bin/bash $i
;;
esac
done
exec /usr/bin/dpkg.real "$@"
SRU REGRESSION POTENTIAL: Very low, the new condition is very specific on the error message in dpkg.log. It could potentially prevent real bugs from being reported if a package file "a.deb" is damaged, but you are trying to install a package "b.deb" in the same run which fails for some other reason. That seems to be a corner case, though, and on a system which managed to corrupt .deb files we do not have a lot of faith in any more anyway.
SRU TEST CASE:
- Move dpkg aside: sudo mv /usr/bin/
- Replace /usr/bin/dpkg with the wrapper from above, and make it executable
- Try to install a package, e. g. "sudo apt-get install pmount"
- Confirm that it fails with "is not a debian format archive"
- Apport should pop up; try to report the bug
- It will succeed in the precise version, but will abort with "cannot be reported" with this fix.
- After that, don't forget to restore dpkg: sudo mv /usr/bin/
Related branches
Changed in apport (Ubuntu Precise): | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Brian Murray (brian-murray) |
Changed in apport (Ubuntu): | |
status: | New → Fix Released |
importance: | Undecided → Medium |
assignee: | nobody → Brian Murray (brian-murray) |
description: | updated |
description: | updated |
Uploaded precise SRU to unapproved.