DEP8 run-test-suite not really running

Bug #1836898 reported by Andreas Hasenack on 2019-07-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apache2 (Ubuntu)
Low
Unassigned
Bionic
Low
Unassigned

Bug Description

Up until 2.4.37-1, the d/t/run-test-suite test isn't running because it's called as root:
(...)
make[1]: Leaving directory '/tmp/autopkgtest.wAqieG/autopkgtest_tmp/perl-framework/c-modules/eat_post'
[ error] Apache cannot spawn child processes as root, therefore the test suite must be run as a non-privileged user.
+ rm apache2.conf.debian
+ run_tests mpm_worker
(...)

This was fixed in 2.4.37-1:
  * Fix test suite to actually run by creating a test user. It turns out
    the test suite refuses to run as root but returns true even in that
    case. It seems this has been broken since 2.4.27-4, where the test suite
    had been updated and the debci test duration dropped from 15min to
    3min. Also, don't rely on the exit status anymore but parse the test
    output.

We should prepare this for bionic, so the next time a bionic SRU comes, it can be incorporated.

Note that a patch is introducing a failure in that suite:
# Test 2 got: "68" (t/apache/mmn.t at line 42)
# Expected: "75"
t/apache/mmn.t ......................
Failed 1/2 subtests

The patch that introduces this failure is debian/patches/balance-member-long-hostname-part2.patch, because it adds this comment:
--- 2.4.x/include/ap_mmn.h 2018/02/16 14:58:32 1824503
+++ 2.4.x/include/ap_mmn.h 2018/02/16 15:04:41 1824504
@@ -496,6 +496,7 @@
  * to ap_[r]getline()
  * 20120211.68 (2.4.26-dev) Add ap_get_basic_auth_components() and deprecate
  * ap_get_basic_auth_pw()
+ * 20120211.75 (2.4.30-dev) Add hostname_ex to proxy_worker_shared
  */

The test compares the version in the comment to the actual #define that happens later on. Since that #define wasn't changed, the test errors.

summary: - test-suite DEP8 not really running
+ DEP8 run-test-suite not really running
Changed in apache2 (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Andreas Hasenack (ahasenack) wrote :

patched run-test-suite so that the suite actually runs, and this is the output

Changed in apache2 (Ubuntu Bionic):
status: New → Triaged
importance: Undecided → Low
Changed in apache2 (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments