snd_seq_free_event() is used in ALSAMidiDriver::read() but it's obsoleted.

Bug #1395718 reported by Takashi Sakamoto
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
amsynth (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The snd_seq_free_event() has been no meaning since 2000. See this commit:
New light-weight event handling
http://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=a7f3ff4a4f3531c98a7875d9789b49a0dc56ab36

Currently snd_seq_event_input() give a pointer to a cell of inner-buffer.
This buffer is kept by snd_seq_open() and released by snd_seq_close().
The size of this buffer is retrieved by snd_seq_get_input_buffer_size() and changed by snd_seq_set_output_buffer_size().

Revision history for this message
Takashi Sakamoto (mocchi) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0001-Remove-snd_seq_free_event-because-it-s-obsoleted-lon.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Pander (pander) wrote :

Please, test it with latest version from https://github.com/amsynth/amsynth or look in the code of it still is a problem or not.

Revision history for this message
Pander (pander) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in amsynth (Ubuntu):
status: New → Confirmed
Revision history for this message
Nick Dowell (nick-nickdowell) wrote :

The call to snd_seq_free_event() has been removed in amsynth 1.7.0

https://github.com/amsynth/amsynth/commit/0b7f204de0ff6d54938962bce1097f703d11e582

Revision history for this message
Pander (pander) wrote :

Please upgrade to 1.7.0, see also https://github.com/amsynth/amsynth/blob/master/NEWS

tags: added: upgrade-software-version zesty
Revision history for this message
dino99 (9d9) wrote :

Really needs an upgrade:
- 1.14 now released https://github.com/amsynth/amsynth
- ubuntu/debian outdated (buggy 1.6.4) and debian homepage deprecated

tags: added: artful bionic
removed: patch zesty
Revision history for this message
Dylan Aïssi (daissi) wrote :

Fixed in at least Disco with amsynth 1.8.0-1

Changed in amsynth (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.