use xdg-open instead of sensible-browser

[Tomas Gustavsson]

Binary package hint: amsn

The first time in aMSN you must chose which software aMSN will call upon when somebody wants to open a file, open a link to a web page etc. This shouldn't be the case so I have created a little patch (nothing fancy, trust me) which maked aMSN use xdg-open per default.

xdg-open is a part of xdg-utils (at least in Ubuntu 7.10) and gets installed in all official Ubuntu distros form the beginning.

I didn't want to change the default for playing sounds (play) because I don't know if xdg-open would handle it that good. One other option is to change the dependency of aMSN to include sox, that's out of my reach.

I hope this will be accepted, having to change something the first time you use it to get it working is not acceptable in my world. Simple fixes are often the best ;).

Please let me know what you think :)

[Christian Reis (kiko)]

Have you seen the latest upload to edgy at https://edge.launchpad.net/ubuntu/hardy/+source/amsn/0.97+final-0ubuntu2 perchance? It seems to fix this exact same issue for browser, at least.

[Tomas Gustavsson (tomplast)]

Hmm, isn't sensible-* tools for Debian only. I know that we targetting Ubuntu-users here but isn't it better to use a tool which is distro-neutral, and as far as I can see sensible-* doesn't offer any advantages over xdg-open in terms of functions.

But I guess it's up to the maintainers to decide about this, personally you know where my vote goes.

[Launchpad Janitor (janitor)]

This bug was fixed in the package amsn - 0.97+final-0ubuntu3

---------------
amsn (0.97+final-0ubuntu3) hardy; urgency=low

  * Updated debian/patches/04_sensible_browserKey.dpatch
    - use xdg-open instead of sensible-browser. (Closes lp: #206639)
  * debian/control:
    - Suggest firefox instead of iceweasel. (Closes lp: #184351)
    - Added dependency on xdg-utils.
  * Closes lp: #206896

 -- <email address hidden> (Cody A.W. Somerville) Tue, 25 Mar 2008 21:05:18 -0300

[Tomas Gustavsson (tomplast)]

This bug isn't fixed, only a partial bit of the patch is applied.

[Cody A.W. Somerville (cody-somerville)]

Sorry. I hadn't applied your patch directly I just made the change myself from memory. I agree with you and will upload a new version shortly. Thanks for pointing this out.

[Launchpad Janitor (janitor)]

This bug was fixed in the package amsn - 0.97+final-0ubuntu4

---------------
amsn (0.97+final-0ubuntu4) hardy; urgency=low

  * Renamed 04_sensible_browserKey.dpatch to 04_use_xdg-open.dpatch
  * debian/patches/04_use_xdg-open.dpatch: Updated.
    - Use xdg-open for file manager, and opening files - not just browser.
    - Closes LP: #206639
    - Closes LP: #208816
  * debian/patches/05-disable_newVersionCheck.dpatch: Created.
    - Path to disable checking of new versions on start by default.
    - Closes LP: #188675
  * debian/patches/06-fix_makefile.dpatch: Created.
    - Ensure proper cleanup and installation of files.
  * debian/rules:
    - clean: Calls to rm removed and makefile patched instead.
    - install: Use dh_installdocs to install docs instead of manually copying.
    - Removed spurious comments and old, commented out commands.
    - General cleanup.
  * debian/amsn.desktop:
    - Deleted, we no longer use it.
    - Closes LP: #184353
  * debian/amsn.docs: Created.
  * debian/patches/00list: Regenerated. Closes LP: #208816

 -- <email address hidden> (Cody A.W. Somerville) Sat, 29 Mar 2008 23:16:00 -0300