[SRU] unused parameter: spf-policyd_time_limit in amavisd-new-postfix

Bug #996569 reported by Birgir Haraldsson on 2012-05-08
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
amavisd-new (Ubuntu)
High
Ante Karamatić
Precise
High
Ante Karamatić
Quantal
High
Ante Karamatić

Bug Description

Please apply this patch to the current 12.04 package.

[Impact]
Every user that installs amavisd-new-postfix will see a warning:

/usr/sbin/postconf: warning: /etc/postfix/main.cf: unused parameter: spf-policyd_time_limit=3600s

This warning will get printed out multiple times. In addition, SPF timeout is never really set, since this parameter is invalid.

[Test case]
1. Install 12.04 with all latest updates
2. Install amavisd-new-postfix
3a. Observe printed warnings
3b. Run 'postconf policy-spf_time_limit'

In case of 3b, broken package will return unknown parameter, while fixed one will return value '3600s'.

[Regression potential]
I've made sure that this parameter is changed on upgrade of the package, fixing this issue for new installs and upgrades. If applied, this fix will remove incorrect parameter by editing /etc/postfix/main.cf and deleting a line that starts with 'spf-policyd_time_limit'. Postfix doesn't have parameters that start with that string, so regression potential will be minimal.

Original report
---------------

When installing amavisd-new-postfix I get multiple errors as such:
/usr/sbin/postconf: warning: /etc/postfix/main.cf: unused parameter: spf-policyd_time_limit=3600s

The correct parameter is "policy-spf_time_limit", not "spf-policyd_time_limit".

Should be easy to fix in line 42 in /debian/amavisd-new-postfix.postinst
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise/amavisd-new/precise/view/head:/debian/amavisd-new-postfix.postinst#L42

amavisd-new-postfix 1:2.6.5-0ubuntu3
Ubuntu 12.04 LTS

James Page (james-page) wrote :

Confirmed:

Setting up amavisd-new-postfix (1:2.6.5-0ubuntu3) ...
postconf: warning: spf-policyd_time_limit: unknown parameter
postconf: warning: /etc/postfix/main.cf: unused parameter: spf-policyd_time_limit=3600s
postconf: warning: /etc/postfix/main.cf: unused parameter: spf-policyd_time_limit=3600s

This is only a warning message but as it could cause messages to be discarded during processing I'm going to mark it as importance 'Medium'

Thanks for reporting this bug in Ubuntu.

Changed in amavisd-new (Ubuntu):
importance: Undecided → Medium
status: New → Triaged

On my server, the incorrect setting causes Postfix to fail to start.

Ubuntu 12.04
mail-stack-delivery 1:2.0.19-0ubuntu1
amavisd-new-postfix 1:2.6.5-0ubuntu3.1

Ante Karamatić (ivoks) on 2012-07-27
Changed in amavisd-new (Ubuntu):
assignee: nobody → Ante Karamatić (ivoks)
status: Triaged → Confirmed
importance: Medium → High
status: Confirmed → In Progress
Ante Karamatić (ivoks) wrote :
Ante Karamatić (ivoks) wrote :
Ante Karamatić (ivoks) wrote :

Once this bug is fixed in Quantal, I'll modify this bug to a SRU request.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package amavisd-new - 1:2.7.1-2ubuntu2

---------------
amavisd-new (1:2.7.1-2ubuntu2) quantal; urgency=low

  * Fix invalid 'spf-policyd_time_limit' parametere in
    amavisd-new-postifx (LP: #996569)
 -- Ante Karamatic <email address hidden> Sun, 29 Jul 2012 10:31:31 +0200

Changed in amavisd-new (Ubuntu Quantal):
status: In Progress → Fix Released
Scott Kitterman (kitterman) wrote :

Quantal/Precise uploaded. Please get the bug worked around for an SRU.

Changed in amavisd-new (Ubuntu Precise):
status: New → In Progress
assignee: nobody → Ante Karamatić (ivoks)
importance: Undecided → High
Ante Karamatić (ivoks) on 2012-07-30
summary: - unused parameter: spf-policyd_time_limit in amavisd-new-postfix
+ [SRU] unused parameter: spf-policyd_time_limit in amavisd-new-postfix
Ante Karamatić (ivoks) on 2012-07-30
description: updated

Hello Birgir, or anyone else affected,

Accepted amavisd-new into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/amavisd-new/1:2.6.5-0ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in amavisd-new (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed

Tested the new package from proposed, and everything worked as expected.
Tested an upgrade of the package with the wrong parameter in main.cf and postinst successfully changed the parameter.
Tested a new install on a fresh system and it worked.

tags: added: verification-done
removed: verification-needed
James Page (james-page) on 2012-07-31
Changed in amavisd-new (Ubuntu Precise):
milestone: none → ubuntu-12.04.1

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package amavisd-new - 1:2.6.5-0ubuntu3.2

---------------
amavisd-new (1:2.6.5-0ubuntu3.2) precise-proposed; urgency=low

  * Replace incorrect parameter 'spf-policyd_time_limit' with a
    correct 'policy-spf_time_limit' (LP: #996569)
 -- Ante Karamatic <email address hidden> Sun, 29 Jul 2012 10:55:26 +0200

Changed in amavisd-new (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers