Soundwire support for CS42L43 and CS35L56 on Intel MTL

Bug #2069760 reported by Chris Chiu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
alsa-ucm-conf (Ubuntu)
Status tracked in Oracular
Noble
In Progress
Undecided
Unassigned
Oracular
In Progress
Undecided
Unassigned
firmware-sof (Ubuntu)
Status tracked in Oracular
Noble
In Progress
Undecided
Unassigned
Oracular
In Progress
Undecided
Unassigned

Bug Description

[SRU Justifications]

========== firmware-sof ==========
[Impact]

Audio doesn't work on Dell new XPS laptops on Intel MTL platforms.

[Fix]

Kernel driver, ALSA ucm, and firmware fixes are required. For firmware-sof, it's the upstream commit 7d2c7f5ad44d ("Add sof-v2.9 for Intel hardware").

[Test Case]
1. Install linux-firmware version >= 20240318.git3b128b60-0ubuntu2.1
2. Install new noble/oracular -proposed alsa UCM conf package
3. Install 6.10-oem kernel
4. Go to audio setting to make sure the audio input/output device are not dummy

[Where problems could occur]
It's simply an additional tplg file which only new kernel driver knows to how to load.

========== alsa-ucm-conf ==========
[Impact]

Audio doesn't work on Dell new XPS laptops on Intel MTL platforms.

[Fix]

Kernel driver, ALSA ucm, and firmware fixes are required. For alsa-ucm-conf, it requires the following upstream commit
1. c0a4df603786 ("sof-soundwire: Use one file for speaker codec")
2. 8e39917518b6 (sof-soundwire: Add basic support for basic cs35l56)
3. e87dde51d689 (sof-soundwire: Add basic support for cs42l43)

[Test Case]
1. Install linux-firmware version >= 20240318.git3b128b60-0ubuntu2.1
2. Install 6.10-oem kernel
3. Install new noble/oracular -proposed firmware-sof package
4. Go to audio setting to make sure the audio input/output device are not dummy

[Where problems could occur]
The new alsa UCM file only take effect when new cs35l56 driver and firmware-sof are loaded. The impact are restricted on cs35l56 only.

Related branches

Chris Chiu (mschiu77)
summary: - Soundwire support for CS42L43 and CS35L56 on Intel LNL/ARL
+ Soundwire support for CS42L43 and CS35L56 on Intel MTL
Chris Chiu (mschiu77)
description: updated
Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Chris Chiu (mschiu77) wrote (last edit ):

Will push a fix for the MR and PPA to coordinate with https://bugs.launchpad.net/ubuntu/+source/firmware-sof/+bug/2069417

Revision history for this message
Chris Chiu (mschiu77) wrote :
Changed in firmware-sof (Ubuntu Noble):
status: New → In Progress
Chris Chiu (mschiu77)
description: updated
Revision history for this message
Chris Chiu (mschiu77) wrote :
Changed in alsa-ucm-conf (Ubuntu Noble):
status: New → In Progress
Chris Chiu (mschiu77)
description: updated
description: updated
description: updated
Chris Chiu (mschiu77)
description: updated
Revision history for this message
Chris Chiu (mschiu77) wrote :
Changed in alsa-ucm-conf (Ubuntu Oracular):
status: New → In Progress
Changed in firmware-sof (Ubuntu Oracular):
status: New → In Progress
Revision history for this message
Dan Bungert (dbungert) wrote :

Hi Chris, this generally looks good, but I have a couple of suggestions:

* the patches are imported from git but have additional information added that doesn't really match https://dep-team.pages.debian.net/~/dep3/ - the Bug-Ubuntu and Origin fields would be ideal to link to the Ubuntu bug and the web location respectively and make it easier to compare the original commit to the actual patches

* we need a distinction in the version numbers between series, so I suggest modifying the Noble MPs to make that distinction, version 1.2.10-1ubuntu5.1 for alsa-ucm-conf on Noble for instance should suffice, and a similar change for firmware-sof, or there is a longer guide on version numbers at https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

* looks like Nick suggested kernel team review on the firmware-sof patches, and the above comments sound like these alsa-ucm-conf/firmware-sof uploads should happen around the same time, so it seems best to not upload alsa-ucm-conf for now pending that review

* Question on the test cases - they mention manually installing a file from upstream, am I correct that this would be provided by the packaging or do we normally expect users to acquire that file from upstream?

Chris Chiu (mschiu77)
description: updated
Revision history for this message
Chris Chiu (mschiu77) wrote :

@Dan, thanks for your suggestion. Some update per your review
- To match the https://dep-team.pages.debian.net/~/dep3/ you mentioned, do you suggest I can modify the `BugLink` field to `Bug-Ubuntu`, and replace the `backported from commit` to `Origin` in my patch file?
- Thanks for pointing out the versioning problem. I've fixed the noble problem per the comment.
- The upstream linux-firmware is no longer required since the file is now in update of linux-firmware 20240318.git3b128b60-0ubuntu2.1 which was not ready yet when I file the SRU (https://launchpad.net/ubuntu/+source/linux-firmware/20240318.git3b128b60-0ubuntu2.1)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.