From crimsun Tue May 2 05:12:25 2006 X-Original-To:crimsun@fungus.sh.nu Return-Path: Delivered-To: crimsun@fungus.sh.nu Received: from localhost (localhost.localdomain [127.0.0.1]) by ns1.mcdownloads.com (Postfix) with ESMTP id 7303A84DD05 for ; Tue, 2 May 2006 04:13:44 -0700 (PDT) Received: from ns1.mcdownloads.com ([216.239.132.98]) by localhost (fungus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 12605-05 for ; Tue, 2 May 2006 04:13:44 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by ns1.mcdownloads.com (Postfix) with ESMTP id D8B3884D3A8 for ; Tue, 2 May 2006 04:13:43 -0700 (PDT) Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 362D51EBCC; Tue, 2 May 2006 13:13:40 +0200 (CEST) Date: Tue, 02 May 2006 13:13:40 +0200 Message-ID: From: Takashi Iwai To: crimsun@fungus.sh.nu Cc: crimsunkg@yahoo.com Subject: Re: Question regarding rbuf access for timer read fix for 32-bit userspace and 64-bit kernel (in cvs revision 1.59 of alsa-lib/src/pcm/pcm_direct.c) In-Reply-To: <20060501055540.GA4143@fungus.sh.nu> References: <20060501055540.GA4143@fungus.sh.nu> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII At Sun, 30 Apr 2006 22:55:40 -0700, crimsun@fungus.sh.nu wrote: > > Takashi, > > While integrating changes for Ubuntu's alsa-lib [0], a question was > raised regarding the access of rbuf in the timer read fix for 32-bit > userspace and 64-bit kernel [1]. The code in question is the call: > > snd_timer_read(dmix->timer, rbuf, sizeof(rbuf)); > > where prior, > > snd_timer_read(dmix->timer, &rbuf, sizeof(rbuf)); > > is used. Is the access method intentional? Yes. rbuf became to an array. Takashi